diff options
| author | guoweis <guoweis@chromium.org> | 2014-12-28 17:17:52 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-29 01:18:41 +0000 |
| commit | feb79eb3e3edf4191ecaaae53808b6132802000d (patch) | |
| tree | fd31ad62524d7d5bdb9fcf683294cb5472597728 | |
| parent | 48fc13b16667c53399774daeccdb1ce5a625578f (diff) | |
| download | chromium_src-feb79eb3e3edf4191ecaaae53808b6132802000d.zip chromium_src-feb79eb3e3edf4191ecaaae53808b6132802000d.tar.gz chromium_src-feb79eb3e3edf4191ecaaae53808b6132802000d.tar.bz2 | |
Change the UMA histogram bucket to help track large video encoded output. The previous change shouldn't use the same UMA as it mixed old and new buckets.
This was to fix the issue from 810833003
BUG=427555
Review URL: https://codereview.chromium.org/825483002
Cr-Commit-Position: refs/heads/master@{#309692}
| -rw-r--r-- | content/renderer/p2p/ipc_socket_factory.cc | 6 | ||||
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 15 |
2 files changed, 17 insertions, 4 deletions
diff --git a/content/renderer/p2p/ipc_socket_factory.cc b/content/renderer/p2p/ipc_socket_factory.cc index 66c6f7e0..3f3ce75 100644 --- a/content/renderer/p2p/ipc_socket_factory.cc +++ b/content/renderer/p2p/ipc_socket_factory.cc @@ -232,10 +232,8 @@ IpcPacketSocket::~IpcPacketSocket() { Close(); } - UMA_HISTOGRAM_CUSTOM_COUNTS("WebRTC.ApplicationMaxConsecutiveBytesDiscard", - max_discard_bytes_sequence_, - 1, 1000000, 200); - + UMA_HISTOGRAM_CUSTOM_COUNTS("WebRTC.ApplicationMaxConsecutiveBytesDiscard.v2", + max_discard_bytes_sequence_, 1, 1000000, 200); if (total_packets_ > 0) { UMA_HISTOGRAM_PERCENTAGE("WebRTC.ApplicationPercentPacketsDiscarded", (packets_discarded_ * 100) / total_packets_); diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index ad1c97e..b3bae76 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -40937,6 +40937,10 @@ Therefore, the affected-histogram name has to have at least one dot in it. </histogram> <histogram name="WebRTC.ApplicationMaxConsecutiveBytesDiscard"> + <obsolete> + Deprecated as of 12/2014, replaced by + WebRTC.ApplicationMaxConsecutiveBytesDiscard.v2. + </obsolete> <owner>guoweis@chromium.org</owner> <summary> The maximum consecutive discarded bytes caused by not enough buffer @@ -40945,6 +40949,17 @@ Therefore, the affected-histogram name has to have at least one dot in it. </summary> </histogram> +<histogram name="WebRTC.ApplicationMaxConsecutiveBytesDiscard.v2"> + <owner>guoweis@chromium.org</owner> + <summary> + The maximum consecutive discarded bytes caused by not enough buffer + available in WebRTC's socket implementation. This happens when WebRTC + IpcPacketSocket's throttling mechanism kicks in. The maximum bucket is + expanded from previous version to provide more insight when upper layer + feeds a lot of packets. + </summary> +</histogram> + <histogram name="WebRTC.ApplicationPercentPacketsDiscarded" units="%"> <owner>guoweis@chromium.org</owner> <summary> |