diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-24 21:53:10 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-24 21:53:10 +0000 |
commit | ff0a441dcd7ea0d1d3544133649db865cf66bda4 (patch) | |
tree | 59948d9d201e37a71aa81f6adbba4537c6acbbe7 | |
parent | 38acae731395abf286d79365480a70fc5fe12021 (diff) | |
download | chromium_src-ff0a441dcd7ea0d1d3544133649db865cf66bda4.zip chromium_src-ff0a441dcd7ea0d1d3544133649db865cf66bda4.tar.gz chromium_src-ff0a441dcd7ea0d1d3544133649db865cf66bda4.tar.bz2 |
Remove GetFileCreationLocalTime. It is unused.
BUG=
Review URL: https://codereview.chromium.org/11896097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178660 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | base/file_util.h | 12 | ||||
-rw-r--r-- | base/file_util_posix.cc | 28 | ||||
-rw-r--r-- | base/file_util_unittest.cc | 35 | ||||
-rw-r--r-- | base/file_util_win.cc | 26 |
4 files changed, 0 insertions, 101 deletions
diff --git a/base/file_util.h b/base/file_util.h index 093365f..ffa4399 100644 --- a/base/file_util.h +++ b/base/file_util.h @@ -153,18 +153,6 @@ BASE_EXPORT bool PathIsWritable(const FilePath& path); // Returns true if the given path exists and is a directory, false otherwise. BASE_EXPORT bool DirectoryExists(const FilePath& path); -#if defined(OS_WIN) -// Gets the creation time of the given file (expressed in the local timezone), -// and returns it via the creation_time parameter. Returns true if successful, -// false otherwise. -BASE_EXPORT bool GetFileCreationLocalTime(const std::wstring& filename, - LPSYSTEMTIME creation_time); - -// Same as above, but takes a previously-opened file handle instead of a name. -BASE_EXPORT bool GetFileCreationLocalTimeFromHandle(HANDLE file_handle, - LPSYSTEMTIME creation_time); -#endif // defined(OS_WIN) - // Returns true if the contents of the two files given are equal, false // otherwise. If either file can't be read, returns false. BASE_EXPORT bool ContentsEqual(const FilePath& filename1, diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc index 7722a5e..0ffa624 100644 --- a/base/file_util_posix.cc +++ b/base/file_util_posix.cc @@ -396,34 +396,6 @@ bool DirectoryExists(const FilePath& path) { return false; } -// TODO(erikkay): implement -#if 0 -bool GetFileCreationLocalTimeFromHandle(int fd, - LPSYSTEMTIME creation_time) { - if (!file_handle) - return false; - - FILETIME utc_filetime; - if (!GetFileTime(file_handle, &utc_filetime, NULL, NULL)) - return false; - - FILETIME local_filetime; - if (!FileTimeToLocalFileTime(&utc_filetime, &local_filetime)) - return false; - - return !!FileTimeToSystemTime(&local_filetime, creation_time); -} - -bool GetFileCreationLocalTime(const std::string& filename, - LPSYSTEMTIME creation_time) { - ScopedHandle file_handle( - CreateFile(filename.c_str(), GENERIC_READ, - FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL, - OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL)); - return GetFileCreationLocalTimeFromHandle(file_handle.Get(), creation_time); -} -#endif - bool ReadFromFD(int fd, char* buffer, size_t bytes) { size_t total_read = 0; while (total_read < bytes) { diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc index 452ee82..b175abf 100644 --- a/base/file_util_unittest.cc +++ b/base/file_util_unittest.cc @@ -1503,41 +1503,6 @@ TEST_F(FileUtilTest, CopyFile) { EXPECT_TRUE(file_util::PathExists(dest_file2)); } -// TODO(erikkay): implement -#if defined(OS_WIN) -TEST_F(FileUtilTest, GetFileCreationLocalTime) { - FilePath file_name = temp_dir_.path().Append(L"Test File.txt"); - - SYSTEMTIME start_time; - GetLocalTime(&start_time); - base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100)); - CreateTextFile(file_name, L"New file!"); - base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100)); - SYSTEMTIME end_time; - GetLocalTime(&end_time); - - SYSTEMTIME file_creation_time; - file_util::GetFileCreationLocalTime(file_name.value(), &file_creation_time); - - FILETIME start_filetime; - SystemTimeToFileTime(&start_time, &start_filetime); - FILETIME end_filetime; - SystemTimeToFileTime(&end_time, &end_filetime); - FILETIME file_creation_filetime; - SystemTimeToFileTime(&file_creation_time, &file_creation_filetime); - - EXPECT_EQ(-1, CompareFileTime(&start_filetime, &file_creation_filetime)) << - "start time: " << FileTimeAsUint64(start_filetime) << ", " << - "creation time: " << FileTimeAsUint64(file_creation_filetime); - - EXPECT_EQ(-1, CompareFileTime(&file_creation_filetime, &end_filetime)) << - "creation time: " << FileTimeAsUint64(file_creation_filetime) << ", " << - "end time: " << FileTimeAsUint64(end_filetime); - - ASSERT_TRUE(DeleteFile(file_name.value().c_str())); -} -#endif - // file_util winds up using autoreleased objects on the Mac, so this needs // to be a PlatformTest. typedef PlatformTest ReadOnlyFileUtilTest; diff --git a/base/file_util_win.cc b/base/file_util_win.cc index c5b2711..2fd2399 100644 --- a/base/file_util_win.cc +++ b/base/file_util_win.cc @@ -302,32 +302,6 @@ bool DirectoryExists(const FilePath& path) { return false; } -bool GetFileCreationLocalTimeFromHandle(HANDLE file_handle, - LPSYSTEMTIME creation_time) { - base::ThreadRestrictions::AssertIOAllowed(); - if (!file_handle) - return false; - - FILETIME utc_filetime; - if (!GetFileTime(file_handle, &utc_filetime, NULL, NULL)) - return false; - - FILETIME local_filetime; - if (!FileTimeToLocalFileTime(&utc_filetime, &local_filetime)) - return false; - - return !!FileTimeToSystemTime(&local_filetime, creation_time); -} - -bool GetFileCreationLocalTime(const std::wstring& filename, - LPSYSTEMTIME creation_time) { - base::ThreadRestrictions::AssertIOAllowed(); - base::win::ScopedHandle file_handle( - CreateFile(filename.c_str(), GENERIC_READ, kFileShareAll, NULL, - OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL)); - return GetFileCreationLocalTimeFromHandle(file_handle.Get(), creation_time); -} - bool GetTempDir(FilePath* path) { base::ThreadRestrictions::AssertIOAllowed(); |