diff options
author | jay <jay@kodewerx.org> | 2015-08-20 10:29:16 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-08-20 17:30:16 +0000 |
commit | 8fc37a38fa2c69db58b45ca5c8bcbd9aa789e1d1 (patch) | |
tree | 9bd9e8c9f04bdd0fbc81973a9d73d8c402ab4352 /AUTHORS | |
parent | 5fb985beb21d826d9027e534550fb1be3961eba5 (diff) | |
download | chromium_src-8fc37a38fa2c69db58b45ca5c8bcbd9aa789e1d1.zip chromium_src-8fc37a38fa2c69db58b45ca5c8bcbd9aa789e1d1.tar.gz chromium_src-8fc37a38fa2c69db58b45ca5c8bcbd9aa789e1d1.tar.bz2 |
[Mac] Fix for Gamepad API disabling itself after switching tabs
The Gamepad API will be "permanently" disabled after switching tabs. The
only way to get it working again is a full restart of the browser.
IOHIDManagerOpen() returns kIOReturnBadArgument after notifications have
been unregistered from I/O Kit.
Since this is all happening within the PauseHint() handler, synthesize
the pausing mechanism with a boolean instead of unregistering and
re-registering with I/O Kit. One subtle difference is that the connect
and disconnect events are still dispatched when paused, which allows
these events to do their magic even when the observing tabs are not
processing gamepad input. This is desirable, IMHO; you don't want to
miss a connect/disconnect event just because the tab isn't focused.
Also there's a stray address-of operator that I noticed on a function
pointer. That was removed for consistency.
BUG=522385,500931
R=bajones@chromium.org
TEST=See crbug.com/522385 and crbug.com/500931 for repro steps.
Review URL: https://codereview.chromium.org/1307513002
Cr-Commit-Position: refs/heads/master@{#344529}
Diffstat (limited to 'AUTHORS')
-rw-r--r-- | AUTHORS | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -250,6 +250,7 @@ Jared Shumway <jaredshumway94@gmail.com> Jared Sohn <jared.sohn@gmail.com> Jared Wein <weinjared@gmail.com> Jari Karppanen <jkarp@amazon.com> +Jay Oster <jay@kodewerx.org> Jay Soffian <jaysoffian@gmail.com> Jeado Ko <haibane84@gmail.com> Jeongeun Kim <je_julie.kim@samsung.com> |