diff options
| author | mlamouri <mlamouri@chromium.org> | 2015-02-27 04:29:11 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-27 12:29:59 +0000 |
| commit | 5675f483e005dddc6a6f494c3edb053c1ca25c71 (patch) | |
| tree | 8954d682d12647c4ef66ccdbb152f8eaa70a129f /BUILD.gn | |
| parent | 3716b0ee1ba634a9ba64eda4bfaf92d9346e90a5 (diff) | |
| download | chromium_src-5675f483e005dddc6a6f494c3edb053c1ca25c71.zip chromium_src-5675f483e005dddc6a6f494c3edb053c1ca25c71.tar.gz chromium_src-5675f483e005dddc6a6f494c3edb053c1ca25c71.tar.bz2 | |
Revert of Add chrome driver to the GN build. (patchset #2 id:20001 of https://codereview.chromium.org/958743003/)
Reason for revert:
Breaks gn builds with os=android.
It would be great to understand why it did not break the bots, though.
Original issue's description:
> Add chrome driver to the GN build.
>
> BUG=
>
> Committed: https://crrev.com/ad912fc2a22d3ddd4c52cb70b487fcb268941ec2
> Cr-Commit-Position: refs/heads/master@{#318272}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/963063002
Cr-Commit-Position: refs/heads/master@{#318437}
Diffstat (limited to 'BUILD.gn')
| -rw-r--r-- | BUILD.gn | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -32,6 +32,7 @@ group("gyp_all") { deps = [ ":gn_all", + # "//chrome/test:chromedriver_unittests", # TODO(GYP) # "//components:components_browsertests", # TODO(GYP) # "//components/nacl:nacl_loader_unittests", # TODO(GYP) # "//google_apis:google_apis_unittests", # TODO(GYP) @@ -60,7 +61,6 @@ group("gn_all") { "//chrome/test:interactive_ui_tests", "//chrome/test:sync_integration_tests", "//chrome/test:unit_tests", - "//chrome/test/chromedriver:chromedriver_unittests", "//components:components_unittests", "//content/shell:content_shell", "//content/test:content_browsertests", @@ -306,6 +306,7 @@ if (is_linux) { group("linux_default_tests") { testonly = true deps = [ + # chromedriver_unittests TODO(GYP) # components_browsertests TODO(GYP) # device_unittests TODO(GYP) # nacl_loader_unittests TODO(GYP) @@ -316,9 +317,8 @@ if (is_linux) { "//cc:cc_unittests", # PASSES 2/25/2015 "//chrome/test:browser_tests", "//chrome/test:interactive_ui_tests", - "//chrome/test:sync_integration_tests", # Crashes for brettw in GN and GYP. + "//chrome/test:sync_integration_tests", # TODO(GYP) multiple crashes. "//chrome/test:unit_tests", # PASSES 2/25/2015 - "//chrome/test/chromedriver:chromedriver_unittests", # PASSES 2/25/2015 "//components:components_unittests", # TODO(GYP) multiple crashes. "//content/test:content_browsertests", "//content/test:content_unittests", # PASSES 2/25/2015 |