summaryrefslogtreecommitdiffstats
path: root/BUILD.gn
diff options
context:
space:
mode:
authorpasko <pasko@chromium.org>2015-04-27 08:55:18 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-27 15:55:20 +0000
commite1ceecf5545568261956de95fda59270a91d4ef0 (patch)
treebdc6da55bb76521c35c3388b42675f4ac5c1d121 /BUILD.gn
parent50b83c1a8d3fe0be4ee0ab62c33c4767981d436a (diff)
downloadchromium_src-e1ceecf5545568261956de95fda59270a91d4ef0.zip
chromium_src-e1ceecf5545568261956de95fda59270a91d4ef0.tar.gz
chromium_src-e1ceecf5545568261956de95fda59270a91d4ef0.tar.bz2
Revert "Intercept base::File Open/Close"
This reverts commit 45a0dc0b75b52e026eb15526ef441edc5dbe9ba5. > Intercept base::File Open/Close > > When a file descriptor is opened by the base::File, all calls to close(3) from > the same dynamic library will hit a CHECK unless they are made from a > whitelist of callsites belonging to base::File. > > There is a handy protect_file_posix.gypi introduced to make it easy to enable > on Chrome-for-Android. > > This 'linker magic' is somewhat crazy, so: > 1. it will be *removed *when crbug.com/424562 is fixed > 2. it should only be used by a whitelist of binaries/libraries (in the > opensource part: libchromeshell only) > > BUG=424562 > > Review URL: https://codereview.chromium.org/676873004 > > Cr-Commit-Position: refs/heads/master@{#304592} Reason: crashes are not numerous, not much sense to fix, some explanations found elsewhere. BUG=424562 Review URL: https://codereview.chromium.org/1101723004 Cr-Commit-Position: refs/heads/master@{#327051}
Diffstat (limited to 'BUILD.gn')
-rw-r--r--BUILD.gn1
1 files changed, 0 insertions, 1 deletions
diff --git a/BUILD.gn b/BUILD.gn
index 867680e..5485277 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -321,7 +321,6 @@ group("gn_all") {
"//base:base_perftests",
"//base:base_i18n_perftests",
"//base:check_example",
- "//base:protect_file_posix",
"//base:build_utf8_validator_tables",
"//cc:cc_perftests",
"//cc/blink:cc_blink_unittests",