diff options
author | dpranke <dpranke@chromium.org> | 2015-10-02 10:58:23 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-10-02 17:59:10 +0000 |
commit | ec10b393f13341c910e87cfd392eb105054dc370 (patch) | |
tree | 9173e3f31565437792a7c4de1882eda6b4594884 /BUILD.gn | |
parent | 5e72f3a449e1e0f4c4f3bc2abede582125e9b438 (diff) | |
download | chromium_src-ec10b393f13341c910e87cfd392eb105054dc370.zip chromium_src-ec10b393f13341c910e87cfd392eb105054dc370.tar.gz chromium_src-ec10b393f13341c910e87cfd392eb105054dc370.tar.bz2 |
Fix build conditions for minidump_stackwalk et al. in GN
Some of the breakpad tools are not meant to be built as iOS (or android)
targets, and do not work on Windows; however, the conditions for
them were incorrectly specified in the build file. This patches
fixes that to make it clear that they should only be built with the host
toolchain.
R=brettw@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1378463005
Cr-Commit-Position: refs/heads/master@{#352075}
Diffstat (limited to 'BUILD.gn')
-rw-r--r-- | BUILD.gn | 17 |
1 files changed, 7 insertions, 10 deletions
@@ -483,15 +483,12 @@ group("both_gn_and_gyp") { "//third_party/sqlite:sqlite_shell", ] - if (current_toolchain == host_toolchain) { - # Do not build the breakpad utilities in cross-compiles. - deps += [ - "//breakpad:dump_syms", - "//breakpad:microdump_stackwalk", - "//breakpad:minidump_dump", - "//breakpad:minidump_stackwalk", - ] - } + deps += [ + "//breakpad:dump_syms($host_toolchain)", + "//breakpad:microdump_stackwalk($host_toolchain)", + "//breakpad:minidump_dump($host_toolchain)", + "//breakpad:minidump_stackwalk($host_toolchain)", + ] if (!is_debug && !is_component_build) { deps += [ "//chrome/tools/service_discovery_sniffer" ] @@ -986,7 +983,7 @@ group("chromium_builder_perf") { ] } } else { - deps += [ "//breakpad:minidump_stackwalk" ] + deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ] } } } |