summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
diff options
context:
space:
mode:
authordbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-15 04:21:36 +0000
committerdbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-15 04:21:36 +0000
commit50c3009dad08aa2ef9ee1d1830585fd95e0beea0 (patch)
treee78fe18949b12ce30655984fd67c3f725095aeac /PRESUBMIT.py
parent8932a2581cfa51f25658d7348e454afe4a18b93a (diff)
downloadchromium_src-50c3009dad08aa2ef9ee1d1830585fd95e0beea0.zip
chromium_src-50c3009dad08aa2ef9ee1d1830585fd95e0beea0.tar.gz
chromium_src-50c3009dad08aa2ef9ee1d1830585fd95e0beea0.tar.bz2
Add linux_clang to default try set so when one runs `git try` or `gcl try` it
will add linux_clang automatically. TEST=Less tree breakage because of not trying changes on clang first. BUG=None NOTRY=true Review URL: http://codereview.chromium.org/9395027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122041 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r--PRESUBMIT.py12
1 files changed, 7 insertions, 5 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index fd1df32..e6ef99b 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -334,13 +334,15 @@ def CheckChangeOnCommit(input_api, output_api):
def GetPreferredTrySlaves(project, change):
- only_objc_files = all(
- f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles())
+ affected_files = change.LocalPaths()
+ only_objc_files = all(f.endswith(('.mm', '.m')) for f in affected_files)
if only_objc_files:
return ['mac_rel']
preferred = ['win_rel', 'linux_rel', 'mac_rel']
+ if any(f.endswith(('.h', '.cc', '.cpp', '.cxx')) for f in affected_files):
+ preferred.append('linux_clang')
aura_re = '_aura[^/]*[.][^/]*'
- if any(re.search(aura_re, f.LocalPath()) for f in change.AffectedFiles()):
+ if any(re.search(aura_re, f) for f in affected_files):
preferred.append('linux_chromeos')
# For bringup (staging of upstream work) we must be careful to not
# overload Android infrastructure. Keeping Android try decisions in a
@@ -351,8 +353,8 @@ def GetPreferredTrySlaves(project, change):
# android builder, use the android try server.
android_re_list = ('^base/', '^ipc/', '^net/', '^sql/', '^jingle/',
'^build/common.gypi$')
- for f in change.AffectedFiles():
- if any(re.search(r, f.LocalPath()) for r in android_re_list):
+ for f in affected_files:
+ if any(re.search(r, f) for r in android_re_list):
preferred.append('android')
break
return preferred