summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
diff options
context:
space:
mode:
authoriannucci <iannucci@chromium.org>2014-08-23 17:39:28 -0700
committerCommit bot <commit-bot@chromium.org>2014-08-24 00:40:25 +0000
commit58d6e64b017cc42f059dee141c8983d70d4c9943 (patch)
treead0896cca1cd6cff43c2885da7f0c3f3a581b9e4 /PRESUBMIT.py
parentcc2b327bf14ae585424208391fe72f03a860bd83 (diff)
downloadchromium_src-58d6e64b017cc42f059dee141c8983d70d4c9943.zip
chromium_src-58d6e64b017cc42f059dee141c8983d70d4c9943.tar.gz
chromium_src-58d6e64b017cc42f059dee141c8983d70d4c9943.tar.bz2
Remove SVN Config PRESUBMIT check.
TBR=maruel@chromium.org R=szager@chromium.org BUG=362394 Review URL: https://codereview.chromium.org/484393003 Cr-Commit-Position: refs/heads/master@{#291613}
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r--PRESUBMIT.py45
1 files changed, 0 insertions, 45 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index c658edf..8afda24 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1281,50 +1281,6 @@ def _CommonChecks(input_api, output_api):
return results
-def _CheckSubversionConfig(input_api, output_api):
- """Verifies the subversion config file is correctly setup.
-
- Checks that autoprops are enabled, returns an error otherwise.
- """
- join = input_api.os_path.join
- if input_api.platform == 'win32':
- appdata = input_api.environ.get('APPDATA', '')
- if not appdata:
- return [output_api.PresubmitError('%APPDATA% is not configured.')]
- path = join(appdata, 'Subversion', 'config')
- else:
- home = input_api.environ.get('HOME', '')
- if not home:
- return [output_api.PresubmitError('$HOME is not configured.')]
- path = join(home, '.subversion', 'config')
-
- error_msg = (
- 'Please look at http://dev.chromium.org/developers/coding-style to\n'
- 'configure your subversion configuration file. This enables automatic\n'
- 'properties to simplify the project maintenance.\n'
- 'Pro-tip: just download and install\n'
- 'http://src.chromium.org/viewvc/chrome/trunk/tools/build/slave/config\n')
-
- try:
- lines = open(path, 'r').read().splitlines()
- # Make sure auto-props is enabled and check for 2 Chromium standard
- # auto-prop.
- if (not '*.cc = svn:eol-style=LF' in lines or
- not '*.pdf = svn:mime-type=application/pdf' in lines or
- not 'enable-auto-props = yes' in lines):
- return [
- output_api.PresubmitNotifyResult(
- 'It looks like you have not configured your subversion config '
- 'file or it is not up-to-date.\n' + error_msg)
- ]
- except (OSError, IOError):
- return [
- output_api.PresubmitNotifyResult(
- 'Can\'t find your subversion config file.\n' + error_msg)
- ]
- return []
-
-
def _CheckAuthorizedAuthor(input_api, output_api):
"""For non-googler/chromites committers, verify the author's email address is
in AUTHORS.
@@ -1564,7 +1520,6 @@ def CheckChangeOnCommit(input_api, output_api):
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api))
- results.extend(_CheckSubversionConfig(input_api, output_api))
return results