diff options
| author | davileen <davileen@amazon.com> | 2015-01-20 14:30:09 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-20 22:32:24 +0000 |
| commit | 72d7653361ab398205c46239ecbc5cd25a85900f (patch) | |
| tree | 957c5f07f74adb9fb10cc6a5031b09e8a90303c3 /PRESUBMIT.py | |
| parent | 620cd76da62ba84f0351750faeb15418933bef83 (diff) | |
| download | chromium_src-72d7653361ab398205c46239ecbc5cd25a85900f.zip chromium_src-72d7653361ab398205c46239ecbc5cd25a85900f.tar.gz chromium_src-72d7653361ab398205c46239ecbc5cd25a85900f.tar.bz2 | |
Allow use of checkstyle outside of main PRESUBMIT.py
This commit allows the use of checkstyle outside of the main PRESUBMIT
script in src. Since checkstyle can possibly be called from a subfolder
of src the absolute path to the java files are used instead of relative
to src.
We also honor the EXCLUDED_PATH blacklist for Java files.
BUG=446633
Review URL: https://codereview.chromium.org/839583006
Cr-Commit-Position: refs/heads/master@{#312287}
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 9bc1f0f..ad5b854 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -1217,7 +1217,8 @@ def _CheckJavaStyle(input_api, output_api): sys.path = original_sys_path return checkstyle.RunCheckstyle( - input_api, output_api, 'tools/android/checkstyle/chromium-style-5.0.xml') + input_api, output_api, 'tools/android/checkstyle/chromium-style-5.0.xml', + black_list=_EXCLUDED_PATHS) def _CheckForCopyrightedCode(input_api, output_api): |