diff options
| author | peter <peter@chromium.org> | 2015-10-20 04:17:46 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-20 11:18:35 +0000 |
| commit | 80739bbf9f719bcf2f74f515c85d945869a779c1 (patch) | |
| tree | 81490cb0a5b4507e813cd83f45855832ff947313 /PRESUBMIT.py | |
| parent | 3f082c0c58857aa2546c0b5fbbba68066ff76e91 (diff) | |
| download | chromium_src-80739bbf9f719bcf2f74f515c85d945869a779c1.zip chromium_src-80739bbf9f719bcf2f74f515c85d945869a779c1.tar.gz chromium_src-80739bbf9f719bcf2f74f515c85d945869a779c1.tar.bz2 | |
Add logging statements to track down why notifications may not respond
We've seen a number of reports where clicking on a notification does not
actually result in the associated Service Worker event being executed. In
an attampt to track down why this is happening, I'm adding some log
statements to make Android logcat output more useful.
These logs will add four messages to the Android logcat output for every
notification that the user explicitly clicks on. (In addition to the
hundreds displayed for other reasons.) We'll take them out when the
issue has been resolved.
BUG=534537
Review URL: https://codereview.chromium.org/1408983003
Cr-Commit-Position: refs/heads/master@{#355034}
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 8d978ff..67b5182 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -1048,6 +1048,9 @@ def _CheckSpamLogging(input_api, output_api): r"^cloud_print[\\\/]", r"^components[\\\/]html_viewer[\\\/]" r"web_test_delegate_impl\.cc$", + # TODO(peter): Remove this exception. https://crbug.com/534537 + r"^content[\\\/]browser[\\\/]notifications[\\\/]" + r"notification_event_dispatcher_impl\.cc$", r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" r"gl_helper_benchmark\.cc$", r"^courgette[\\\/]courgette_tool\.cc$", |