diff options
| author | blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-23 12:10:05 +0000 |
|---|---|---|
| committer | blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-23 12:10:05 +0000 |
| commit | ed295ecf6dd36dda6b34c88ae84e487130749fd0 (patch) | |
| tree | 2bb202d73f10d73a37cd4919234f099f83f61456 /PRESUBMIT.py | |
| parent | 2b1a592a168970a3aa5908df022b2d8966e2dcd4 (diff) | |
| download | chromium_src-ed295ecf6dd36dda6b34c88ae84e487130749fd0.zip chromium_src-ed295ecf6dd36dda6b34c88ae84e487130749fd0.tar.gz chromium_src-ed295ecf6dd36dda6b34c88ae84e487130749fd0.tar.bz2 | |
Revert of Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object. (https://codereview.chromium.org/283413002/)
Reason for revert:
Introduced flake on Mac: crbug.com/376550
Original issue's description:
> Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object.
>
> The goal of this CL is to eliminate the dependence of
> GoogleURLTracker(MapEntry) on NavigationController. To accomplish this goal,
> GoogleURLTrackerNavigationHelper is turned into a conceptually per-tab
> interface. GoogleURLTracker::OnNavigationPending() now takes in the
> GoogleURLTrackerNavigationHelper with which the navigation is associated rather
> than the associated NavigationController; GoogleURLTracker performs per-tab
> actions by calling the navigation helper associated with the tab.
>
> A followup CL will turn GoogleURLTrackerNavigationHelper(Impl) into the
> GoogleURLTrackerDriver interface and ContentURLTrackerDriver implementation.
>
> BUG=373230
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272094
TBR=pkasting@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373230
Review URL: https://codereview.chromium.org/294193005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272503 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
0 files changed, 0 insertions, 0 deletions