summaryrefslogtreecommitdiffstats
path: root/WATCHLISTS
diff options
context:
space:
mode:
authorbrettw <brettw@chromium.org>2015-12-02 11:19:57 -0800
committerCommit bot <commit-bot@chromium.org>2015-12-02 19:20:32 +0000
commit38aa9811fec66706f122aeeb29590a57deb0fcd0 (patch)
tree6367078c921d3cdfd390716c97d25ac50d1ebe46 /WATCHLISTS
parent9a0d1ce534626cd9b3dbd5c3ead89f573d78df74 (diff)
downloadchromium_src-38aa9811fec66706f122aeeb29590a57deb0fcd0.zip
chromium_src-38aa9811fec66706f122aeeb29590a57deb0fcd0.tar.gz
chromium_src-38aa9811fec66706f122aeeb29590a57deb0fcd0.tar.bz2
Run certain chrome_elf_unittests only in Release.
These tests depend on various parts of base not getting included in chrome_elf.dll as described in the comment added to the unit test file. This doesn't work in GN debug build because the GN build uses source sets rather than shared libraries. This change runs the test only in release mode. This replaces the dependencies on base_static with base and removes the comment about not depending on all of base. All of base is getting linked in via the sandbox dependency, so this effort is wasted. The regular base dependency is clearer. Slight iterator improvements in the update unit tests for readability. Independently, this fixes the linking of chrome_child with symbols on Windows. The conditions were messed up. The code meant to force incremental linking off when full symbols are enabled, but actually did the reverse. BUG=505062 Review URL: https://codereview.chromium.org/1485343002 Cr-Commit-Position: refs/heads/master@{#362767}
Diffstat (limited to 'WATCHLISTS')
0 files changed, 0 insertions, 0 deletions