diff options
| author | timvolodine <timvolodine@chromium.org> | 2015-07-14 09:13:16 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-14 16:13:59 +0000 |
| commit | 66cc354b26d07f64e8ee6327dc5ad6d5db9b8f66 (patch) | |
| tree | b5fa33ceb21648644cbdb0b8b36ac75400bf4090 /android_webview/android_webview.gyp | |
| parent | 1e720d2f120ba0cf3293a642285af3d9d987f28e (diff) | |
| download | chromium_src-66cc354b26d07f64e8ee6327dc5ad6d5db9b8f66.zip chromium_src-66cc354b26d07f64e8ee6327dc5ad6d5db9b8f66.tar.gz chromium_src-66cc354b26d07f64e8ee6327dc5ad6d5db9b8f66.tar.bz2 | |
Refactor some browser-side chrome and webview printing code into component/printing/browser.
This patch refactors both the clank and webview code paths
on the browser-side. It moves the common bits to
components/printing/browser/, in particular the following changes
have been performed:
- significantly refactor print_manager and print_view_manager code
and extract common bits into a super class.
- use a callback to signal PdfWritingDone instead of PrintManagerDelegate.
This improves decoupling and also makes it possible to unify the clank side
of the code.
- extract common methods into functions in print_manager_utils.
BUG=465802
Review URL: https://codereview.chromium.org/1024883002
Cr-Commit-Position: refs/heads/master@{#338697}
Diffstat (limited to 'android_webview/android_webview.gyp')
| -rw-r--r-- | android_webview/android_webview.gyp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/android_webview/android_webview.gyp b/android_webview/android_webview.gyp index 7bd371f..f10e195 100644 --- a/android_webview/android_webview.gyp +++ b/android_webview/android_webview.gyp @@ -172,6 +172,7 @@ '../components/components.gyp:devtools_discovery', '../components/components.gyp:navigation_interception', '../components/components.gyp:printing_common', + '../components/components.gyp:printing_browser', '../components/components.gyp:printing_renderer', '../components/components.gyp:visitedlink_browser', '../components/components.gyp:visitedlink_renderer', @@ -238,6 +239,8 @@ 'browser/aw_permission_manager.h', 'browser/aw_pref_store.cc', 'browser/aw_pref_store.h', + 'browser/aw_print_manager.cc', + 'browser/aw_print_manager.h', 'browser/aw_printing_message_filter.cc', 'browser/aw_printing_message_filter.h', 'browser/aw_quota_manager_bridge.cc', @@ -295,8 +298,6 @@ 'browser/renderer_host/aw_render_view_host_ext.h', 'browser/renderer_host/aw_resource_dispatcher_host_delegate.cc', 'browser/renderer_host/aw_resource_dispatcher_host_delegate.h', - 'browser/renderer_host/print_manager.cc', - 'browser/renderer_host/print_manager.h', 'browser/scoped_allow_wait_for_legacy_web_view_api.h', 'browser/scoped_app_gl_state_restore.cc', 'browser/scoped_app_gl_state_restore.h', |