diff options
| author | peter <peter@chromium.org> | 2014-11-14 19:51:33 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-15 03:52:45 +0000 |
| commit | 3e3627a8aebace63f6379ce6d6c030ee96ff58fd (patch) | |
| tree | 65cdb345819f49bc007ef94baa1631d949467a3e /android_webview/browser | |
| parent | d8d83f0b0a1367dc50fc4733ba4325d4b244b85f (diff) | |
| download | chromium_src-3e3627a8aebace63f6379ce6d6c030ee96ff58fd.zip chromium_src-3e3627a8aebace63f6379ce6d6c030ee96ff58fd.tar.gz chromium_src-3e3627a8aebace63f6379ce6d6c030ee96ff58fd.tar.bz2 | |
The default Web Notification permission should be denied.
When the content embedder does not (or only partially) implement support
for Web Notifications, permission calls for the API should not be telling
other code-paths that it's granted. This causes confusing behavior for
the Web exposed API.
BUG=398070
Review URL: https://codereview.chromium.org/420283003
Cr-Commit-Position: refs/heads/master@{#304337}
Diffstat (limited to 'android_webview/browser')
| -rw-r--r-- | android_webview/browser/aw_content_browser_client.cc | 18 | ||||
| -rw-r--r-- | android_webview/browser/aw_content_browser_client.h | 11 |
2 files changed, 0 insertions, 29 deletions
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc index b29821b..8af695f 100644 --- a/android_webview/browser/aw_content_browser_client.cc +++ b/android_webview/browser/aw_content_browser_client.cc @@ -375,24 +375,6 @@ void AwContentBrowserClient::SelectClientCertificate( } } -blink::WebNotificationPermission - AwContentBrowserClient::CheckDesktopNotificationPermission( - const GURL& source_url, - content::ResourceContext* context, - int render_process_id) { - // Android WebView does not support notifications, so return Denied here. - return blink::WebNotificationPermissionDenied; -} - -void AwContentBrowserClient::ShowDesktopNotification( - const content::ShowDesktopNotificationHostMsgParams& params, - content::BrowserContext* browser_context, - int render_process_id, - scoped_ptr<content::DesktopNotificationDelegate> delegate, - base::Closure* cancel_callback) { - NOTREACHED() << "Android WebView does not support desktop notifications."; -} - void AwContentBrowserClient::RequestPermission( content::PermissionType permission, content::WebContents* web_contents, diff --git a/android_webview/browser/aw_content_browser_client.h b/android_webview/browser/aw_content_browser_client.h index 9bd6f03..f9507a6 100644 --- a/android_webview/browser/aw_content_browser_client.h +++ b/android_webview/browser/aw_content_browser_client.h @@ -108,17 +108,6 @@ class AwContentBrowserClient : public content::ContentBrowserClient { int render_frame_id, net::SSLCertRequestInfo* cert_request_info, const base::Callback<void(net::X509Certificate*)>& callback) override; - virtual blink::WebNotificationPermission - CheckDesktopNotificationPermission( - const GURL& source_url, - content::ResourceContext* context, - int render_process_id) override; - virtual void ShowDesktopNotification( - const content::ShowDesktopNotificationHostMsgParams& params, - content::BrowserContext* browser_context, - int render_process_id, - scoped_ptr<content::DesktopNotificationDelegate> delegate, - base::Closure* cancel_callback) override; virtual void RequestPermission( content::PermissionType permission, content::WebContents* web_contents, |