diff options
author | msw <msw@chromium.org> | 2016-02-02 17:25:06 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-03 01:26:34 +0000 |
commit | 456d842422a8cf9954ebeab7615059a0129812de (patch) | |
tree | 66113703585a40588dcb52d8bbf779805b8f3788 /android_webview/browser | |
parent | 91375c125e08b6b53bb7c7e3eaedab1ef7c08a0b (diff) | |
download | chromium_src-456d842422a8cf9954ebeab7615059a0129812de.zip chromium_src-456d842422a8cf9954ebeab7615059a0129812de.tar.gz chromium_src-456d842422a8cf9954ebeab7615059a0129812de.tar.bz2 |
Revert of Delete base/prefs and update callers to use components. (patchset #3 id:40001 of https://codereview.chromium.org/1662523004/ )
Reason for revert:
Broke Win Builder compile:
https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19463/steps/compile/logs/stdio
Original issue's description:
> Delete base/prefs and update callers to use components.
>
> Deletes the forwarding headers in base/prefs.
>
> Updates the remaining users of base/prefs includes to use components/prefs.
> Sort headers in updated files.
>
> Move PrefServiceFactory out of the base namespace. Update users.
>
> Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
> COMPONENTS_PREFS_.
>
> Add components/prefs to DEPS file of directories where checkdeps fails after
> the update.
>
> BUG=583034
>
> Committed: https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef
> Cr-Commit-Position: refs/heads/master@{#373105}
TBR=estade@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583034
Review URL: https://codereview.chromium.org/1662843002
Cr-Commit-Position: refs/heads/master@{#373115}
Diffstat (limited to 'android_webview/browser')
5 files changed, 8 insertions, 8 deletions
diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc index a5e985f..0003e2e 100644 --- a/android_webview/browser/aw_browser_context.cc +++ b/android_webview/browser/aw_browser_context.cc @@ -20,6 +20,8 @@ #include "base/base_paths_android.h" #include "base/bind.h" #include "base/path_service.h" +#include "base/prefs/pref_service.h" +#include "base/prefs/pref_service_factory.h" #include "components/autofill/core/common/autofill_pref_names.h" #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h" #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h" @@ -33,8 +35,6 @@ #include "components/policy/core/browser/configuration_policy_pref_store.h" #include "components/policy/core/browser/url_blacklist_manager.h" #include "components/pref_registry/pref_registry_syncable.h" -#include "components/prefs/pref_service.h" -#include "components/prefs/pref_service_factory.h" #include "components/url_formatter/url_fixer.h" #include "components/user_prefs/user_prefs.h" #include "components/visitedlink/browser/visitedlink_master.h" @@ -347,7 +347,7 @@ void AwBrowserContext::InitUserPrefService() { metrics::MetricsService::RegisterPrefs(pref_registry); - PrefServiceFactory pref_service_factory; + base::PrefServiceFactory pref_service_factory; pref_service_factory.set_user_prefs(make_scoped_refptr(new AwPrefStore())); pref_service_factory.set_managed_prefs( make_scoped_refptr(new policy::ConfigurationPolicyPrefStore( diff --git a/android_webview/browser/aw_metrics_service_client.cc b/android_webview/browser/aw_metrics_service_client.cc index 26d465f..eb07828 100644 --- a/android_webview/browser/aw_metrics_service_client.cc +++ b/android_webview/browser/aw_metrics_service_client.cc @@ -9,6 +9,7 @@ #include "base/files/file_util.h" #include "base/guid.h" #include "base/i18n/rtl.h" +#include "base/prefs/pref_service.h" #include "components/metrics/call_stack_profile_metrics_provider.h" #include "components/metrics/gpu/gpu_metrics_provider.h" #include "components/metrics/metrics_pref_names.h" @@ -18,7 +19,6 @@ #include "components/metrics/profiler/profiler_metrics_provider.h" #include "components/metrics/ui/screen_info_metrics_provider.h" #include "components/metrics/url_constants.h" -#include "components/prefs/pref_service.h" #include "content/public/browser/browser_thread.h" namespace android_webview { diff --git a/android_webview/browser/aw_pref_store.h b/android_webview/browser/aw_pref_store.h index 6607e25..b3fd021 100644 --- a/android_webview/browser/aw_pref_store.h +++ b/android_webview/browser/aw_pref_store.h @@ -12,8 +12,8 @@ #include "base/compiler_specific.h" #include "base/macros.h" #include "base/observer_list.h" -#include "components/prefs/persistent_pref_store.h" -#include "components/prefs/pref_value_map.h" +#include "base/prefs/persistent_pref_store.h" +#include "base/prefs/pref_value_map.h" // A light-weight prefstore implementation that keeps preferences // in a memory backed store. This is not a persistent prefstore -- we diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc index 7b54fa9..7ab710f 100644 --- a/android_webview/browser/net/aw_url_request_context_getter.cc +++ b/android_webview/browser/net/aw_url_request_context_getter.cc @@ -19,13 +19,13 @@ #include "base/bind.h" #include "base/command_line.h" #include "base/files/file_path.h" +#include "base/prefs/pref_service.h" #include "base/strings/string_number_conversions.h" #include "base/threading/sequenced_worker_pool.h" #include "base/threading/worker_pool.h" #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h" #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h" #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h" -#include "components/prefs/pref_service.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/content_browser_client.h" #include "content/public/browser/cookie_store_factory.h" diff --git a/android_webview/browser/net/aw_url_request_context_getter.h b/android_webview/browser/net/aw_url_request_context_getter.h index 46c2146..bdafa05 100644 --- a/android_webview/browser/net/aw_url_request_context_getter.h +++ b/android_webview/browser/net/aw_url_request_context_getter.h @@ -9,7 +9,7 @@ #include "base/files/file_path.h" #include "base/macros.h" #include "base/memory/scoped_ptr.h" -#include "components/prefs/pref_member.h" +#include "base/prefs/pref_member.h" #include "content/public/browser/content_browser_client.h" #include "net/url_request/url_request_context_getter.h" #include "net/url_request/url_request_job_factory.h" |