diff options
| author | gsennton <gsennton@chromium.org> | 2015-10-05 05:03:28 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-05 12:04:34 +0000 |
| commit | e5c3091df04749b232359b6ef22938006af840d5 (patch) | |
| tree | a799e646553e566351c397e48ec9cf7afa097065 /android_webview/common | |
| parent | 36d974b6b1d6166a25bd03b894bfdf646872a0b1 (diff) | |
| download | chromium_src-e5c3091df04749b232359b6ef22938006af840d5.zip chromium_src-e5c3091df04749b232359b6ef22938006af840d5.tar.gz chromium_src-e5c3091df04749b232359b6ef22938006af840d5.tar.bz2 | |
Revert "Use resource throttle to implement shouldOverrideUrlLoading, core change"
Reverting because of crbug.com/534758, to fix that bug we will have to
make a blink change adding a callback to let WebView know when a
document is not longer loading. The current callback DidFinishLoad does
not fire if a new load is in its provisional state, which is sometimes
the case if we load a webpage containing a redirect in the form of a
href assignment: window.location.href = '...'.
This revert was not clean because of the transition to using
NavigationThrottles over in https://codereview.chromium.org/1363483007
This reverts commit 777bb78a111aee919e07f5206267915a87639f88.
TBR=palmer@chromium.org,jam@chromium.org
BUG=534758
Review URL: https://codereview.chromium.org/1375993004
Cr-Commit-Position: refs/heads/master@{#352318}
Diffstat (limited to 'android_webview/common')
| -rw-r--r-- | android_webview/common/render_view_messages.h | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/android_webview/common/render_view_messages.h b/android_webview/common/render_view_messages.h index 91dbb5b..bdd6711 100644 --- a/android_webview/common/render_view_messages.h +++ b/android_webview/common/render_view_messages.h @@ -104,6 +104,19 @@ IPC_MESSAGE_ROUTED1(AwViewHostMsg_PageScaleFactorChanged, IPC_MESSAGE_ROUTED1(AwViewHostMsg_OnContentsSizeChanged, gfx::Size /* contents_size */) +// Sent immediately before a top level navigation is initiated within Blink. +// There are some exlusions, the most important ones are it is not sent +// when creating a popup window, and not sent for application initiated +// navigations. See AwContentRendererClient::HandleNavigation for all +// cornercases. This is sent before updating the NavigationController state +// or creating a URLRequest for the main frame resource. +IPC_SYNC_MESSAGE_CONTROL4_1(AwViewHostMsg_ShouldOverrideUrlLoading, + int /* render_frame_id id */, + base::string16 /* in - url */, + bool /* in - has_user_gesture */, + bool /* in - is_redirect */, + bool /* out - result */) + // Sent when a subframe is created. IPC_MESSAGE_CONTROL2(AwViewHostMsg_SubFrameCreated, int /* parent_render_frame_id */, |