diff options
author | mnaganov <mnaganov@chromium.org> | 2015-12-11 11:12:49 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-11 19:14:43 +0000 |
commit | 412d1a272f9f7b68803ca5932e96049ae86171be (patch) | |
tree | 47ec72626e2ccc227634868e7a45a4a34db880f2 /android_webview/crash_reporter | |
parent | 2748c5cea72b053e64920d9bce3bd0440ba5d22d (diff) | |
download | chromium_src-412d1a272f9f7b68803ca5932e96049ae86171be.zip chromium_src-412d1a272f9f7b68803ca5932e96049ae86171be.tar.gz chromium_src-412d1a272f9f7b68803ca5932e96049ae86171be.tar.bz2 |
[Android WebView] Update microdump generation for sandboxed renderers
Now microdump handling has three modes depending on the process type:
"webview" -- displays crash dialog, supports dump on demand;
"" (browser) -- displays crash dialog, doesn't support dump on demand;
"renderer" -- doesn't display crash dialog, no dump on demand.
Dump on demand may be enabled later if we figure out how to do it
properly for sandboxed renderers.
Exported `InitMicrodumpCrashHandlerIfNecessary` as calling
`InitNonBrowserCrashReporterForAndroid` for that purpose is misleading,
and WebView doesn't need any of the functionality that it can enable.
BUG=568825
Review URL: https://codereview.chromium.org/1518913002
Cr-Commit-Position: refs/heads/master@{#364766}
Diffstat (limited to 'android_webview/crash_reporter')
-rw-r--r-- | android_webview/crash_reporter/aw_microdump_crash_reporter.cc | 5 | ||||
-rw-r--r-- | android_webview/crash_reporter/aw_microdump_crash_reporter.h | 2 |
2 files changed, 3 insertions, 4 deletions
diff --git a/android_webview/crash_reporter/aw_microdump_crash_reporter.cc b/android_webview/crash_reporter/aw_microdump_crash_reporter.cc index 165c4b3..aac36e8 100644 --- a/android_webview/crash_reporter/aw_microdump_crash_reporter.cc +++ b/android_webview/crash_reporter/aw_microdump_crash_reporter.cc @@ -109,7 +109,7 @@ bool SafeToUseSignalHandler() { } // namespace -void EnableMicrodumpCrashReporter() { +void EnableMicrodumpCrashReporter(const std::string& process_type) { if (g_enabled) { NOTREACHED() << "EnableMicrodumpCrashReporter called more than once"; return; @@ -124,8 +124,7 @@ void EnableMicrodumpCrashReporter() { ::crash_reporter::SetCrashReporterClient(g_crash_reporter_client.Pointer()); - // |process_type| is not really relevant here, as long as it not empty. - breakpad::InitNonBrowserCrashReporterForAndroid("webview" /* process_type */); + breakpad::InitMicrodumpCrashHandlerIfNecessary(process_type); g_enabled = true; } diff --git a/android_webview/crash_reporter/aw_microdump_crash_reporter.h b/android_webview/crash_reporter/aw_microdump_crash_reporter.h index 067363f..ae567a8 100644 --- a/android_webview/crash_reporter/aw_microdump_crash_reporter.h +++ b/android_webview/crash_reporter/aw_microdump_crash_reporter.h @@ -10,7 +10,7 @@ namespace android_webview { namespace crash_reporter { -void EnableMicrodumpCrashReporter(); +void EnableMicrodumpCrashReporter(const std::string& process_type); void AddGpuFingerprintToMicrodumpCrashHandler( const std::string& gpu_fingerprint); bool DumpWithoutCrashingToFd(int fd); |