summaryrefslogtreecommitdiffstats
path: root/android_webview/tools
diff options
context:
space:
mode:
authortimvolodine <timvolodine@chromium.org>2015-12-07 09:35:54 -0800
committerCommit bot <commit-bot@chromium.org>2015-12-07 17:36:43 +0000
commit4af45e81999060a801b54aaa711b32959736c89a (patch)
treea8691dbdc4e439763530411818bed88cde6e76e9 /android_webview/tools
parenta9683e5ced448d46254bd1d0caea289059be7f79 (diff)
downloadchromium_src-4af45e81999060a801b54aaa711b32959736c89a.zip
chromium_src-4af45e81999060a801b54aaa711b32959736c89a.tar.gz
chromium_src-4af45e81999060a801b54aaa711b32959736c89a.tar.bz2
[SystemWebViewShellLayoutTest] Make testNoUnexpectedInterfaces non-failing.
WebViewLayoutTest.testNoUnexpectedInterfaces fails when new interfaces are added to webview without updating the expectation files. In practice this amounts to sheriffs either 'blindly' rebasing the expectation file or just disabling this test. This patch makes this test non-failing to be able to catch new interfaces without annoying the sheriff. Normally new exposed interfaces should be verified whether they actually work and should be exposed in webview. BUG=564765 Review URL: https://codereview.chromium.org/1501333004 Cr-Commit-Position: refs/heads/master@{#363505}
Diffstat (limited to 'android_webview/tools')
-rw-r--r--android_webview/tools/WebViewShellTest/src/org/chromium/webview_shell/test/WebViewLayoutTest.java12
1 files changed, 6 insertions, 6 deletions
diff --git a/android_webview/tools/WebViewShellTest/src/org/chromium/webview_shell/test/WebViewLayoutTest.java b/android_webview/tools/WebViewShellTest/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
index 9942776..59ebd81 100644
--- a/android_webview/tools/WebViewShellTest/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
+++ b/android_webview/tools/WebViewShellTest/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
@@ -11,7 +11,6 @@ import android.test.suitebuilder.annotation.MediumTest;
import junit.framework.ComparisonFailure;
import org.chromium.base.Log;
-import org.chromium.base.test.util.DisabledTest;
import org.chromium.webview_shell.WebViewLayoutTestActivity;
import java.io.BufferedReader;
@@ -83,11 +82,9 @@ public class WebViewLayoutTest
"webexposed/global-interface-listing-expected.txt", true);
}
- /*
+ // This is a non-failing test to avoid 'blind' rebaselines by the sheriff
+ // (see crbug.com/564765).
@MediumTest
- crbug.com/564765
- */
- @DisabledTest
public void testNoUnexpectedInterfaces() throws Exception {
ensureJsTestCopied();
loadUrlWebViewAsync("file://" + PATH_BLINK_PREFIX
@@ -108,7 +105,10 @@ public class WebViewLayoutTest
newInterfaces.append(interfaceS + "\n");
}
}
- assertEquals("Unexpected new webview interfaces found", "", newInterfaces.toString());
+
+ if (newInterfaces.length() > 0) {
+ Log.w(TAG, "Unexpected WebView interfaces found: " + newInterfaces.toString());
+ }
}
@MediumTest