summaryrefslogtreecommitdiffstats
path: root/android_webview
diff options
context:
space:
mode:
authorajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-28 06:51:42 +0000
committerajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-28 06:51:42 +0000
commit5ff8b2aa66ed64f18794cfb130284bb54eb00ce4 (patch)
treee411d23a1b3144aad9819741adb7154ef2b0ac3c /android_webview
parent3945dcb435eb9ebcad8ba582663fd50cb8a59126 (diff)
downloadchromium_src-5ff8b2aa66ed64f18794cfb130284bb54eb00ce4.zip
chromium_src-5ff8b2aa66ed64f18794cfb130284bb54eb00ce4.tar.gz
chromium_src-5ff8b2aa66ed64f18794cfb130284bb54eb00ce4.tar.bz2
Cleanup storage_partition_impl_unittest.cc.
Removes: - unnecessary casts - unnecessary conversions to pointers - unnecessary wrapper over RunLoop. It also removes stack-based creation of the StoragePartition and temp directories. This was fragile and unnecessary. The TestBrowserContext itself already created a default one. The stack-based version was actually coopting contexts that were created in the default partition to create a partial stub. This unfortunately also avoided most of the initialization code and checks in the StoragePartitionImpl::Create() function leading to more fragility. Now, each test case only has one default StoragePartition which is correctly tied to the containing BrowserContext. The contexts in this partition are also no longer shared by the stubs. TBR=boliu BUG=none Review URL: https://codereview.chromium.org/101423007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242675 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview')
-rw-r--r--android_webview/native/aw_quota_manager_bridge_impl.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/android_webview/native/aw_quota_manager_bridge_impl.cc b/android_webview/native/aw_quota_manager_bridge_impl.cc
index f672f8b..4821732 100644
--- a/android_webview/native/aw_quota_manager_bridge_impl.cc
+++ b/android_webview/native/aw_quota_manager_bridge_impl.cc
@@ -215,7 +215,7 @@ void AwQuotaManagerBridgeImpl::DeleteAllDataOnUiThread() {
StoragePartition::REMOVE_DATA_MASK_LOCAL_STORAGE |
StoragePartition::REMOVE_DATA_MASK_WEBSQL,
StoragePartition::QUOTA_MANAGED_STORAGE_MASK_TEMPORARY,
- NULL, StoragePartition::OriginMatcherFunction(),
+ GURL(), StoragePartition::OriginMatcherFunction(),
base::Time(), base::Time::Max(), base::Bind(&base::DoNothing));
}