diff options
| author | torne@chromium.org <torne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-21 12:49:20 +0000 |
|---|---|---|
| committer | torne@chromium.org <torne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-21 12:49:20 +0000 |
| commit | d7a471d3f4f6cad3218f74e1c87a6ceea7acba03 (patch) | |
| tree | 69a073a4e3b3db4dc7a46d44ca73178aaccd9a7c /android_webview | |
| parent | dd3bd27fb5f314aec7ebc5cc4b9404b59fa468b6 (diff) | |
| download | chromium_src-d7a471d3f4f6cad3218f74e1c87a6ceea7acba03.zip chromium_src-d7a471d3f4f6cad3218f74e1c87a6ceea7acba03.tar.gz chromium_src-d7a471d3f4f6cad3218f74e1c87a6ceea7acba03.tar.bz2 | |
Android WebView: use IO thread for cookie manager.
Instead of posting tasks to the FILE thread, use the IO thread to match
the rest of Chromium (which normally only calls CookieMonster on the IO
thread). This is a workaround for a possible thread safety issue in
CookieMonster, but it's fine to change this permanently as the original
choice of the FILE thread was not significant.
BUG=308589
Review URL: https://codereview.chromium.org/28943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229789 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview')
| -rw-r--r-- | android_webview/native/cookie_manager.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/android_webview/native/cookie_manager.cc b/android_webview/native/cookie_manager.cc index 387068f..cd43f30 100644 --- a/android_webview/native/cookie_manager.cc +++ b/android_webview/native/cookie_manager.cc @@ -35,7 +35,7 @@ using net::CookieMonster; // See issue http://crbug.com/157683 // All functions on the CookieManager can be called from any thread, including -// threads without a message loop. BrowserThread::FILE is used to call methods +// threads without a message loop. BrowserThread::IO is used to call methods // on CookieMonster that needs to be called, and called back, on a chrome // thread. @@ -124,7 +124,7 @@ void CookieManager::ExecCookieTask(const CookieTask& task, DCHECK(cookie_monster_.get()); - BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE, + BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(task, wait_for_completion ? &completion : NULL)); if (wait_for_completion) { |