diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-19 18:47:05 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-19 18:47:05 +0000 |
| commit | 28164cbf4787643ad22efc12b439ba0cff93cc63 (patch) | |
| tree | dc6b1ecd04b34252755b6b6452859cb6ee6ad667 /app/win | |
| parent | 416ed618e916018bb154acd52fd39ca1198efd22 (diff) | |
| download | chromium_src-28164cbf4787643ad22efc12b439ba0cff93cc63.zip chromium_src-28164cbf4787643ad22efc12b439ba0cff93cc63.tar.gz chromium_src-28164cbf4787643ad22efc12b439ba0cff93cc63.tar.bz2 | |
Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making sure we
clean up props we still leak in a handful of cases that are causing
test grief. By and large our usage of properties is for inside the
application, so that a map works fine.
BUG=61528 44991
Review URL: http://codereview.chromium.org/5075003
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/5184009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66786 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app/win')
| -rw-r--r-- | app/win/scoped_prop.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/app/win/scoped_prop.h b/app/win/scoped_prop.h index c309e52..14e6a6a 100644 --- a/app/win/scoped_prop.h +++ b/app/win/scoped_prop.h @@ -18,12 +18,6 @@ namespace win { // cleanup. ScopedProp must be destroyed before the window is destroyed, else // you're going to leak a property, which could lead to failure to set a // property later on. -// -// *WARNING* -// SetProp is very fragile. SetProp makes use of a finite chunk of memory that -// is very easy to exhaust. Unless you need to share a property across process -// boundaries you should instead use ViewProp, which does not cause leaks at the -// window manager. class ScopedProp { public: // Registers the key value pair for the specified window. ScopedProp does not |