diff options
| author | jdufault <jdufault@chromium.org> | 2015-06-25 18:26:16 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-26 01:27:57 +0000 |
| commit | 7efb92fb895b22f73f943b191f2da02527a55cd3 (patch) | |
| tree | 8a4539297775bc6be646269688ebaab1a756c4c4 /ash/ash_chromeos_strings.grdp | |
| parent | cb74965e5aab713293d9ba6dffa1b87ab1da872e (diff) | |
| download | chromium_src-7efb92fb895b22f73f943b191f2da02527a55cd3.zip chromium_src-7efb92fb895b22f73f943b191f2da02527a55cd3.tar.gz chromium_src-7efb92fb895b22f73f943b191f2da02527a55cd3.tar.bz2 | |
Add utility methods for device type translation messages.
The high-level goal is to remove hard-coded device-types in UI strings; these utility methods make it very easy to substitute in the correct device-type at runtime.
This CL uses a method introduced in https://codereview.chromium.org/1204783005.
These utility methods are used in the following CL's:
- https://codereview.chromium.org/1172053004
- https://codereview.chromium.org/1175803002
- https://codereview.chromium.org/1164423011
- https://codereview.chromium.org/1173823002
- https://codereview.chromium.org/1176673002
- https://codereview.chromium.org/1170373003
- https://codereview.chromium.org/1175813002
A presubmit check is introduced in a later CL to prevent accidentally hard-coding device-type messages (https://codereview.chromium.org/1171063003).
BUG=341356
Review URL: https://codereview.chromium.org/1206063002
Cr-Commit-Position: refs/heads/master@{#336313}
Diffstat (limited to 'ash/ash_chromeos_strings.grdp')
| -rw-r--r-- | ash/ash_chromeos_strings.grdp | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/ash/ash_chromeos_strings.grdp b/ash/ash_chromeos_strings.grdp index dec9def..35b98fd 100644 --- a/ash/ash_chromeos_strings.grdp +++ b/ash/ash_chromeos_strings.grdp @@ -3,6 +3,23 @@ Everything in this file is wrapped in <if expr="chromeos">. --> <grit-part> + <!-- Device types --> + <message name="IDS_ASH_CHROMEBASE" desc="The device name for a Chromebase (versus say Chromebox)"> + Chromebase + </message> + <message name="IDS_ASH_CHROMEBIT" desc="The device name for a Chromebit (versus say Chromebox)"> + Chromebit + </message> + <message name="IDS_ASH_CHROMEBOOK" desc="The device name for a Chromebook (versus say Chromebox)"> + Chromebook + </message> + <message name="IDS_ASH_CHROMEBOX" desc="The device name for a Chromebox (versus say Chromebook)"> + Chromebox + </message> + <message name="IDS_ASH_CHROMEDEVICE" desc="The device name for a generic Chrome device"> + Chrome device + </message> + <!-- Status tray charging strings. --> <message name="IDS_ASH_STATUS_TRAY_LOW_POWER_CHARGER_TITLE" desc="The title of a notification indicating that a low-current USB charger has been connected."> Low-power charger connected |