diff options
| author | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-14 17:16:21 +0000 |
|---|---|---|
| committer | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-14 17:16:21 +0000 |
| commit | 5eebaf46e7ea120921c3fcfce64ea45047659641 (patch) | |
| tree | 6afa9a413c557de459ee0ad4c997bd26404ebffe /ash/drag_drop | |
| parent | 25cc762f00cbc1904e997f789078162e51e91418 (diff) | |
| download | chromium_src-5eebaf46e7ea120921c3fcfce64ea45047659641.zip chromium_src-5eebaf46e7ea120921c3fcfce64ea45047659641.tar.gz chromium_src-5eebaf46e7ea120921c3fcfce64ea45047659641.tar.bz2 | |
events: Update key-event handlers to not return EventResult.
BUG=163618
Review URL: https://codereview.chromium.org/11570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173171 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/drag_drop')
| -rw-r--r-- | ash/drag_drop/drag_drop_controller.cc | 5 | ||||
| -rw-r--r-- | ash/drag_drop/drag_drop_controller.h | 2 |
2 files changed, 3 insertions, 4 deletions
diff --git a/ash/drag_drop/drag_drop_controller.cc b/ash/drag_drop/drag_drop_controller.cc index f3d0343..91aa4a7 100644 --- a/ash/drag_drop/drag_drop_controller.cc +++ b/ash/drag_drop/drag_drop_controller.cc @@ -285,12 +285,11 @@ bool DragDropController::IsDragDropInProgress() { return !!drag_drop_tracker_.get(); } -ui::EventResult DragDropController::OnKeyEvent(ui::KeyEvent* event) { +void DragDropController::OnKeyEvent(ui::KeyEvent* event) { if (IsDragDropInProgress() && event->key_code() == ui::VKEY_ESCAPE) { DragCancel(); - return ui::ER_CONSUMED; + event->StopPropagation(); } - return ui::ER_UNHANDLED; } ui::EventResult DragDropController::OnMouseEvent(ui::MouseEvent* event) { diff --git a/ash/drag_drop/drag_drop_controller.h b/ash/drag_drop/drag_drop_controller.h index bef79a0..49dfb65ed 100644 --- a/ash/drag_drop/drag_drop_controller.h +++ b/ash/drag_drop/drag_drop_controller.h @@ -65,7 +65,7 @@ class ASH_EXPORT DragDropController virtual bool IsDragDropInProgress() OVERRIDE; // Overridden from ui::EventHandler: - virtual ui::EventResult OnKeyEvent(ui::KeyEvent* event) OVERRIDE; + virtual void OnKeyEvent(ui::KeyEvent* event) OVERRIDE; virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE; virtual void OnTouchEvent(ui::TouchEvent* event) OVERRIDE; virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE; |