summaryrefslogtreecommitdiffstats
path: root/ash/frame
diff options
context:
space:
mode:
authoreroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-30 17:05:34 +0000
committereroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-30 17:05:34 +0000
commit3d48423a74668a7cfd71ba895a2c510ec85447b5 (patch)
treeddab0640a79caf30a151825cb706be7113157363 /ash/frame
parent11f9efbe87642781a5e03fc760cc16c7f31a97f9 (diff)
downloadchromium_src-3d48423a74668a7cfd71ba895a2c510ec85447b5.zip
chromium_src-3d48423a74668a7cfd71ba895a2c510ec85447b5.tar.gz
chromium_src-3d48423a74668a7cfd71ba895a2c510ec85447b5.tar.bz2
Revert 267195 "Password bubble: ManagePasswordsIconView is now a..."
> Password bubble: ManagePasswordsIconView is now a BubbleIconView. > > This CL introduces a new browser command to open the Manage Passwords bubble, > and converts the ManagePasswordsIconView class into a subclass of > BubbleIconView, which uses the new command to control the bubble's state. > This allows us to more easily test the view and the UI controller, as each > object's job is now more clearly defined (and the view is now doing a good > deal less work), and to independently verify that the command is doing the > right thing. > > After this CL, we'll (finally!) have something approaching reasonable test > coverage for the core of the views code. > > ---------------------------------------------------------------------------- > This is a re-land of r266859, which was reverted due to LSAN errors. The > original review is https://codereview.chromium.org/246393004/ > ---------------------------------------------------------------------------- > > BUG=365678 > TBR=vabr@chromium.org,pkasting@chromium.org,cpu@chromium.org > > Review URL: https://codereview.chromium.org/254263002 TBR=mkwst@chromium.org Review URL: https://codereview.chromium.org/261663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267249 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/frame')
0 files changed, 0 insertions, 0 deletions