summaryrefslogtreecommitdiffstats
path: root/ash/shell
diff options
context:
space:
mode:
authorafakhry <afakhry@chromium.org>2015-09-09 02:03:42 -0700
committerCommit bot <commit-bot@chromium.org>2015-09-09 09:05:09 +0000
commitcd2bb98dd450f65d857700df192a34ee79d618bf (patch)
tree947a8b130671159ac013024626b12a710303e881 /ash/shell
parent422d099ed5b8439b92d198deb84d4528c14ccc0c (diff)
downloadchromium_src-cd2bb98dd450f65d857700df192a34ee79d618bf.zip
chromium_src-cd2bb98dd450f65d857700df192a34ee79d618bf.tar.gz
chromium_src-cd2bb98dd450f65d857700df192a34ee79d618bf.tar.bz2
Deprecating high-conflict accelerators
This CL designs a framework for deprecated accelerators. In this CL we deprecate the following accelerators: - Lock Screen: Ctrl+Shift+L --> Search+L - Task Manager: Shift+Esc --> Search+Esc The old accelerators are still enabled, but the user is shown a notification message telling him about the new accelerator. UMA stats are recorded for both old and new accelerators. Keyboard overlay has been updated. BUG=492454,486198,498565,405317,503351 TEST=manually, ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*, ash_unittests --gtest_filter=AcceleratorTableTest.CheckDeprecatedAccelerators Committed: https://crrev.com/c2b81c9fca4abc10cafdc75d2e7b4f15314e2e5b Cr-Commit-Position: refs/heads/master@{#335410} Review URL: https://codereview.chromium.org/1177773002 Cr-Commit-Position: refs/heads/master@{#347865}
Diffstat (limited to 'ash/shell')
-rw-r--r--ash/shell/shell_delegate_impl.cc5
-rw-r--r--ash/shell/shell_delegate_impl.h1
2 files changed, 6 insertions, 0 deletions
diff --git a/ash/shell/shell_delegate_impl.cc b/ash/shell/shell_delegate_impl.cc
index 4cd2172..735cd0d 100644
--- a/ash/shell/shell_delegate_impl.cc
+++ b/ash/shell/shell_delegate_impl.cc
@@ -24,6 +24,7 @@
#include "components/user_manager/user_info_impl.h"
#include "ui/app_list/app_list_view_delegate.h"
#include "ui/aura/window.h"
+#include "ui/gfx/image/image.h"
namespace ash {
namespace shell {
@@ -269,5 +270,9 @@ base::string16 ShellDelegateImpl::GetProductName() const {
return base::string16();
}
+gfx::Image ShellDelegateImpl::GetDeprecatedAcceleratorImage() const {
+ return gfx::Image();
+}
+
} // namespace shell
} // namespace ash
diff --git a/ash/shell/shell_delegate_impl.h b/ash/shell/shell_delegate_impl.h
index 255401a..6c054c3 100644
--- a/ash/shell/shell_delegate_impl.h
+++ b/ash/shell/shell_delegate_impl.h
@@ -63,6 +63,7 @@ class ShellDelegateImpl : public ash::ShellDelegate {
ash::ShelfItem* item) override;
GPUSupport* CreateGPUSupport() override;
base::string16 GetProductName() const override;
+ gfx::Image GetDeprecatedAcceleratorImage() const override;
private:
// Used to update Launcher. Owned by main.