diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-05 04:19:35 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-05 04:19:35 +0000 |
| commit | 1966d6d1568191bb984efd30f20d884553e35450 (patch) | |
| tree | cac5a77663b4c5a976970be83ad9dff926ed4599 /ash/system/tray/fixed_sized_scroll_view.h | |
| parent | fc18b9eacd5657f6ebc3b5f9e6a72ddcf751896e (diff) | |
| download | chromium_src-1966d6d1568191bb984efd30f20d884553e35450.zip chromium_src-1966d6d1568191bb984efd30f20d884553e35450.tar.gz chromium_src-1966d6d1568191bb984efd30f20d884553e35450.tar.bz2 | |
Removes FocusBorder from views
This patch removes FocusBorder from View along with
View::OnPaintFocusBorder. Views that want to render focus and that
need to allow overriding get a Painter that is responsible for
rendering the focus. Views that render focus differently must override
OnFocus/OnBlur to SchedulePaint the necessary region.
This patch simplifies View and cleans things up for views that don't
ever want to paint focus, or paint focus differently (say TableView,
or Textfield). On the down side it does mean any view that is
focusable needs to override a few more additional methods. It was easy
to get this wrong previously though as a common pattern is to
override OnPaint and not invoke View::OnPaint.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/105013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238888 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/system/tray/fixed_sized_scroll_view.h')
| -rw-r--r-- | ash/system/tray/fixed_sized_scroll_view.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ash/system/tray/fixed_sized_scroll_view.h b/ash/system/tray/fixed_sized_scroll_view.h index c5d9bc0..aff53c2 100644 --- a/ash/system/tray/fixed_sized_scroll_view.h +++ b/ash/system/tray/fixed_sized_scroll_view.h @@ -33,7 +33,6 @@ class FixedSizedScrollView : public views::ScrollView { protected: // Overridden from views::View: virtual void OnBoundsChanged(const gfx::Rect& previous_bounds) OVERRIDE; - virtual void OnPaintFocusBorder(gfx::Canvas* canvas) OVERRIDE; private: gfx::Size fixed_size_; |