System modal dialog unhide shelf launcher, and prevents going into maximized mode.

When shelf is auto hidden, displaying a system modal dialog used to
unhide it. That was because the ShelfLayoutManager when updating the
shelf visibility, it used to ask the MruWindowTracker to build a list of
the windows. This list used to exclude the unfocusable windows (due to
the system modal dialog), So the returned list used to be empty which
means the shelf should be unhidden.

We actually need the list of all visible windows regardless of their
focusability.

Two unit tests has been written to validate the correct behavior in both
single and dual display modes.

BUG=277893, 447720
TEST=ash_unittests --gtest_filter=ShelfLayoutManagerTest.ShelfWithSystemModalWindowSingleDisplay, ShelfLayoutManagerTest.ShelfWithSystemModalWindowDualDisplay, MaximizeModeWindowManagerTest.GoingToMaximizedWithModalDialogPresent

Review URL: https://codereview.chromium.org/780113002

Cr-Commit-Position: refs/heads/master@{#311063}

1 files changed, 4 insertions, 0 deletions

diff --git a/ash/wm/ash_focus_rules.h b/ash/wm/ash_focus_rules.h
index f32ce87..70cf56997 100644
--- a/ash/wm/ash_focus_rules.h
+++ b/ash/wm/ash_focus_rules.h
@@ -18,6 +18,10 @@ class ASH_EXPORT AshFocusRules : public ::wm::BaseFocusRules {
   AshFocusRules();
   ~AshFocusRules() override;
 
+  // Tests if the given |window| can be activated, ignoring the system modal
+  // dialog state.
+  bool IsWindowConsideredActivatable(aura::Window* window) const;
+
  private:
   // Overridden from ::wm::BaseFocusRules:
   bool SupportsChildActivation(aura::Window* window) const override;