summaryrefslogtreecommitdiffstats
path: root/ash/wm/maximize_mode/maximize_mode_window_manager.cc
diff options
context:
space:
mode:
authornsatragno@chromium.org <nsatragno@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-29 19:11:08 +0000
committernsatragno@chromium.org <nsatragno@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-29 19:11:08 +0000
commitdf547c6d208020e0cf6da2f4075e0b5c399b3db5 (patch)
tree353d275fc73eefd9cd01928d36462d54e4727137 /ash/wm/maximize_mode/maximize_mode_window_manager.cc
parent78a68137b2ac1e0e4b8bf7d574eaaa44287ce854 (diff)
downloadchromium_src-df547c6d208020e0cf6da2f4075e0b5c399b3db5.zip
chromium_src-df547c6d208020e0cf6da2f4075e0b5c399b3db5.tar.gz
chromium_src-df547c6d208020e0cf6da2f4075e0b5c399b3db5.tar.bz2
Using tap gesture instead of touch to activate windows in overview mode
This brings some improvements over the old touch event handling: * Window is activated on the full tap gesture, which is consistent with the mouse click event handling. * The user can now cancel the gesture by sliding the finger out of the window bounds without releasing it (not activating any window). * In the future it is going to be much easier to add support for other gestures, e.g. fling to dismiss. Just handling the tap is not sufficient as the browser window might consume touches, therefore preventing the generation of tap gestures under our current architecture. To circumvent this, I'm adding a transparent window on top of the overview items, which covers the entire bounding box. An added feature is that the transparent window covers the entire bounding box, even for panels, making them easier to click. As a subproduct of this patch locking the cursor is no longer necessary, so we fix a bug related to that, too. Finally, by handling the OnWindowActivated instead of manually restoring the windows when they are clicked, we fix a bug caused by activating the window from the shelf. BUG=336601,322688,368671,374283 TEST=WindowSelectorTest.BasicGesture, WindowSelectorTest.WindowDoesNotReceiveEvents, WindowSelectorTest.CloseButton Review URL: https://codereview.chromium.org/269423008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273537 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/wm/maximize_mode/maximize_mode_window_manager.cc')
-rw-r--r--ash/wm/maximize_mode/maximize_mode_window_manager.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager.cc b/ash/wm/maximize_mode/maximize_mode_window_manager.cc
index 15278bf..788f3bf 100644
--- a/ash/wm/maximize_mode/maximize_mode_window_manager.cc
+++ b/ash/wm/maximize_mode/maximize_mode_window_manager.cc
@@ -31,7 +31,7 @@ void CancelOverview() {
WindowSelectorController* controller =
Shell::GetInstance()->window_selector_controller();
if (controller && controller->IsSelecting())
- controller->OnSelectionCanceled();
+ controller->OnSelectionEnded();
}
} // namespace