summaryrefslogtreecommitdiffstats
path: root/ash/wm/shelf_layout_manager.cc
diff options
context:
space:
mode:
authorabodenha@chromium.org <abodenha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-29 18:17:43 +0000
committerabodenha@chromium.org <abodenha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-29 18:17:43 +0000
commit86627fb5d652b9f717c9fe7a9d56924b3026c3cd (patch)
treecb6b6a0c302dbccc770a2cf2642e6fa3449e325b /ash/wm/shelf_layout_manager.cc
parent5836c076093386525e9b23743039962625bc02b5 (diff)
downloadchromium_src-86627fb5d652b9f717c9fe7a9d56924b3026c3cd.zip
chromium_src-86627fb5d652b9f717c9fe7a9d56924b3026c3cd.tar.gz
chromium_src-86627fb5d652b9f717c9fe7a9d56924b3026c3cd.tar.bz2
Revert 144930 - Polish launcher tooltip visibility.
Add ShelfLayoutManager::Observer for two cases: - AutoHide: catches the auto hiding status to close the tooltip property - FullScreen: catches the shelf visibility changes to close it too Check the visibility of Shelf itself in case of tooltip showing. Then the toolip won't show if the shelf is hidden. R=derat@chromium.org,davemoore@chromium.org BUG=133551 TEST=manually done on lumpy, made sure aura_shell_unittests passed Review URL: https://chromiumcodereview.appspot.com/10700030 TBR=mukai@chromium.org Review URL: https://chromiumcodereview.appspot.com/10701042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144934 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/wm/shelf_layout_manager.cc')
-rw-r--r--ash/wm/shelf_layout_manager.cc15
1 files changed, 0 insertions, 15 deletions
diff --git a/ash/wm/shelf_layout_manager.cc b/ash/wm/shelf_layout_manager.cc
index cf0c624..156fad1 100644
--- a/ash/wm/shelf_layout_manager.cc
+++ b/ash/wm/shelf_layout_manager.cc
@@ -279,8 +279,6 @@ void ShelfLayoutManager::UpdateAutoHideState() {
if (auto_hide_state == AUTO_HIDE_HIDDEN) {
// Hides happen immediately.
SetState(state_.visibility_state);
- FOR_EACH_OBSERVER(Observer, observers_,
- OnAutoHideStateChanged(auto_hide_state));
} else {
auto_hide_timer_.Stop();
auto_hide_timer_.Start(
@@ -298,14 +296,6 @@ void ShelfLayoutManager::SetWindowOverlapsShelf(bool value) {
UpdateShelfBackground(internal::BackgroundAnimator::CHANGE_ANIMATE);
}
-void ShelfLayoutManager::AddObserver(Observer* observer) {
- observers_.AddObserver(observer);
-}
-
-void ShelfLayoutManager::RemoveObserver(Observer* observer) {
- observers_.RemoveObserver(observer);
-}
-
////////////////////////////////////////////////////////////////////////////////
// ShelfLayoutManager, aura::LayoutManager implementation:
@@ -355,9 +345,6 @@ void ShelfLayoutManager::SetState(VisibilityState visibility_state) {
if (state_.Equals(state))
return; // Nothing changed.
- FOR_EACH_OBSERVER(Observer, observers_,
- WillVisibilityStateChange(visibility_state));
-
if (state.visibility_state == AUTO_HIDE) {
// When state is AUTO_HIDE we need to track when the mouse is over the
// launcher to unhide the shelf. AutoHideEventFilter does that for us.
@@ -520,8 +507,6 @@ bool ShelfLayoutManager::GetLauncherPaintsBackground() const {
void ShelfLayoutManager::UpdateAutoHideStateNow() {
SetState(state_.visibility_state);
- FOR_EACH_OBSERVER(Observer, observers_, OnAutoHideStateChanged(
- CalculateAutoHideState(state_.visibility_state)));
}
ShelfLayoutManager::AutoHideState ShelfLayoutManager::CalculateAutoHideState(