diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-07 22:17:35 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-07 22:17:35 +0000 |
| commit | 126d8b5e3a7efa3e2584de4c1bc31c6460233ca6 (patch) | |
| tree | 91c7311d1161422ffdf91b9ce0a222a345c03ffe /base/BUILD.gn | |
| parent | 44b4f0e59d30953db7cd89dd95266f0f5973e1da (diff) | |
| download | chromium_src-126d8b5e3a7efa3e2584de4c1bc31c6460233ca6.zip chromium_src-126d8b5e3a7efa3e2584de4c1bc31c6460233ca6.tar.gz chromium_src-126d8b5e3a7efa3e2584de4c1bc31c6460233ca6.tar.bz2 | |
Add optional public header checking to GN build
You can invoke this either using the "--check" argument to the gen command (for use on buildbots) or by running "gn check" (for developer on-demand use).
This adds support for "public" headers for a target, and an optional "--check" flag to the gen command that implements checkdeps-like include checking. Basically if you include a file that's declared in the build, it has to be in the public section of one of your dependents (or that dependent doesn't have a public section, which implies everything is public).
This roughly maps to Blaze's behavior around the public headers.
Moves modp_b64 build file to main tree.
Remove modp_b64 hack for older versions of VC missing stdint (this included basictypes which caused a header check failure).
I also added some base dependencies and some other minor build changes to solve some other issues identified by the check. The remaining one is that a file in base/metrics depends on ipc (!)
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/216903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262216 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/BUILD.gn')
| -rw-r--r-- | base/BUILD.gn | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/base/BUILD.gn b/base/BUILD.gn index 7aa8659..468d76c 100644 --- a/base/BUILD.gn +++ b/base/BUILD.gn @@ -6,7 +6,6 @@ import("//build/config/ui.gni") component("base") { sources = [ - "../build/build_config.h", "third_party/dmg_fp/dmg_fp.h", "third_party/dmg_fp/g_fmt.cc", "third_party/dmg_fp/dtoa_wrapper.cc", @@ -368,6 +367,10 @@ component("base") { "native_library_mac.mm", "native_library_posix.cc", "native_library_win.cc", + "numerics/safe_conversions.h", + "numerics/safe_conversions_impl.h", + "numerics/safe_math.h", + "numerics/safe_math_impl.h", "nix/mime_util_xdg.cc", "nix/mime_util_xdg.h", "nix/xdg_util.cc", @@ -391,7 +394,6 @@ component("base") { "port.h", "posix/eintr_wrapper.h", "posix/file_descriptor_shuffle.cc", - "posix/file_descriptor_shuffle.y", "posix/global_descriptors.cc", "posix/global_descriptors.h", "posix/unix_domain_socket_linux.cc", @@ -453,7 +455,6 @@ component("base") { "process/process_metrics_posix.cc", "process/process_metrics_win.cc", "process/process_posix.cc", - "process/process_util.h", "process/process_win.cc", "profiler/scoped_profile.cc", "profiler/scoped_profile.h", @@ -468,7 +469,6 @@ component("base") { "rand_util_win.cc", "run_loop.cc", "run_loop.h", - "safe_numerics.h", "safe_strerror_posix.cc", "safe_strerror_posix.h", "scoped_generic.h", |