diff options
author | danakj <danakj@chromium.org> | 2015-03-09 17:31:16 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-03-10 00:32:24 +0000 |
commit | 0a44860ef0cce93998ebc97f0631beae418e07ce (patch) | |
tree | 53368f5ac669d6d61dbe76d55e56076254d1a430 /base/android | |
parent | a025878158db6fe6946bf49691a91ca896e2648c (diff) | |
download | chromium_src-0a44860ef0cce93998ebc97f0631beae418e07ce.zip chromium_src-0a44860ef0cce93998ebc97f0631beae418e07ce.tar.gz chromium_src-0a44860ef0cce93998ebc97f0631beae418e07ce.tar.bz2 |
base: Fix/add header #ifndef guards.
Header guards should be defined based on the path and file name of the
header file. Some headers have it wrong, some are missing the guards,
and some just have the matching comment wrong.
R=Nico
BUG=464816
Committed: https://crrev.com/301b392761fd8f66f3a701ab1dd011c6e7a55e19
Cr-Commit-Position: refs/heads/master@{#319722}
Review URL: https://codereview.chromium.org/985003004
Cr-Commit-Position: refs/heads/master@{#319793}
Diffstat (limited to 'base/android')
-rw-r--r-- | base/android/important_file_writer_android.h | 6 | ||||
-rw-r--r-- | base/android/java_handler_thread.h | 6 | ||||
-rw-r--r-- | base/android/jni_generator/sample_for_tests.h | 5 | ||||
-rw-r--r-- | base/android/library_loader/library_load_from_apk_status_codes.h | 6 | ||||
-rw-r--r-- | base/android/library_loader/library_loader_hooks.h | 6 | ||||
-rw-r--r-- | base/android/trace_event_binding.h | 6 |
6 files changed, 20 insertions, 15 deletions
diff --git a/base/android/important_file_writer_android.h b/base/android/important_file_writer_android.h index 20956ba..88e4441 100644 --- a/base/android/important_file_writer_android.h +++ b/base/android/important_file_writer_android.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef NATIVE_FRAMEWORK_CHROME_IMPORTANT_FILE_WRITE_ANDROID_H_ -#define NATIVE_FRAMEWORK_CHROME_IMPORTANT_FILE_WRITE_ANDROID_H_ +#ifndef BASE_ANDROID_IMPORTANT_FILE_WRITER_ANDROID_H_ +#define BASE_ANDROID_IMPORTANT_FILE_WRITER_ANDROID_H_ #include <jni.h> @@ -15,4 +15,4 @@ bool RegisterImportantFileWriterAndroid(JNIEnv* env); } // namespace android } // namespace base -#endif // NATIVE_FRAMEWORK_CHROME_IMPORTANT_FILE_WRITE_ANDROID_H_ +#endif // BASE_ANDROID_IMPORTANT_FILE_WRITER_ANDROID_H_ diff --git a/base/android/java_handler_thread.h b/base/android/java_handler_thread.h index 7cd274d..c9a2c02 100644 --- a/base/android/java_handler_thread.h +++ b/base/android/java_handler_thread.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef BASE_THREADING_JAVA_THREAD_H_ -#define BASE_THREADING_JAVA_THREAD_H_ +#ifndef BASE_ANDROID_JAVA_HANDLER_THREAD_H_ +#define BASE_ANDROID_JAVA_HANDLER_THREAD_H_ #include <jni.h> @@ -46,4 +46,4 @@ class BASE_EXPORT JavaHandlerThread { } // namespace android } // namespace base -#endif // BASE_THREADING_JAVA_THREAD_H_ +#endif // BASE_ANDROID_JAVA_HANDLER_THREAD_H_ diff --git a/base/android/jni_generator/sample_for_tests.h b/base/android/jni_generator/sample_for_tests.h index 4d76408..c98cf97 100644 --- a/base/android/jni_generator/sample_for_tests.h +++ b/base/android/jni_generator/sample_for_tests.h @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#ifndef BASE_ANDROID_JNI_GENERATOR_SAMPLE_FOR_TESTS_H_ +#define BASE_ANDROID_JNI_GENERATOR_SAMPLE_FOR_TESTS_H_ + #include <jni.h> #include <map> #include <string> @@ -48,3 +51,5 @@ class CPPClass { } // namespace android } // namespace base + +#endif // BASE_ANDROID_JNI_GENERATOR_SAMPLE_FOR_TESTS_H_ diff --git a/base/android/library_loader/library_load_from_apk_status_codes.h b/base/android/library_loader/library_load_from_apk_status_codes.h index f99eebc..9591d3f 100644 --- a/base/android/library_loader/library_load_from_apk_status_codes.h +++ b/base/android/library_loader/library_load_from_apk_status_codes.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef BASE_ANDROID_LIBRARY_LOAD_FROM_APK_STATUS_CODES_H_ -#define BASE_ANDROID_LIBRARY_LOAD_FROM_APK_STATUS_CODES_H_ +#ifndef BASE_ANDROID_LIBRARY_LOADER_LIBRARY_LOAD_FROM_APK_STATUS_CODES_H_ +#define BASE_ANDROID_LIBRARY_LOADER_LIBRARY_LOAD_FROM_APK_STATUS_CODES_H_ namespace base { namespace android { @@ -43,4 +43,4 @@ enum LibraryLoadFromApkStatusCodes { } // namespace android } // namespace base -#endif // BASE_ANDROID_LIBRARY_LOAD_FROM_APK_STATUS_CODES_H_ +#endif // BASE_ANDROID_LIBRARY_LOADER_LIBRARY_LOAD_FROM_APK_STATUS_CODES_H_ diff --git a/base/android/library_loader/library_loader_hooks.h b/base/android/library_loader/library_loader_hooks.h index 7e8d527..b1624a0 100644 --- a/base/android/library_loader/library_loader_hooks.h +++ b/base/android/library_loader/library_loader_hooks.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef BASE_ANDROID_LIBRARY_LOADER_HOOKS_H_ -#define BASE_ANDROID_LIBRARY_LOADER_HOOKS_H_ +#ifndef BASE_ANDROID_LIBRARY_LOADER_LIBRARY_LOADER_HOOKS_H_ +#define BASE_ANDROID_LIBRARY_LOADER_LIBRARY_LOADER_HOOKS_H_ #include <jni.h> @@ -67,4 +67,4 @@ BASE_EXPORT LibraryProcessType GetLibraryProcessType(JNIEnv* env); } // namespace android } // namespace base -#endif // BASE_ANDROID_LIBRARY_LOADER_HOOKS_H_ +#endif // BASE_ANDROID_LIBRARY_LOADER_LIBRARY_LOADER_HOOKS_H_ diff --git a/base/android/trace_event_binding.h b/base/android/trace_event_binding.h index ed06266..1c1a60b 100644 --- a/base/android/trace_event_binding.h +++ b/base/android/trace_event_binding.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef BASE_ANDROID_TRACE_EVENT_H_ -#define BASE_ANDROID_TRACE_EVENT_H_ +#ifndef BASE_ANDROID_TRACE_EVENT_BINDING_H_ +#define BASE_ANDROID_TRACE_EVENT_BINDING_H_ #include <jni.h> @@ -15,4 +15,4 @@ extern bool RegisterTraceEvent(JNIEnv* env); } // namespace android } // namespace base -#endif // CONTENT_COMMON_ANDROID_TRACE_EVENT_H_ +#endif // BASE_ANDROID_TRACE_EVENT_BINDING_H_ |