diff options
| author | steveblock@chromium.org <steveblock@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-05 14:42:08 +0000 |
|---|---|---|
| committer | steveblock@chromium.org <steveblock@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-05 14:42:08 +0000 |
| commit | 96e7adeaf0086d53217e7a6c175af9defca386b7 (patch) | |
| tree | 874b4aef50b9d3ed6f6ca43f5ecc181ee3411734 /base/base.gyp | |
| parent | 393206600991bdae7c6a6d2ee5f35a1039d80f31 (diff) | |
| download | chromium_src-96e7adeaf0086d53217e7a6c175af9defca386b7.zip chromium_src-96e7adeaf0086d53217e7a6c175af9defca386b7.tar.gz chromium_src-96e7adeaf0086d53217e7a6c175af9defca386b7.tar.bz2 | |
Don't use Singleton to cache JNI method IDs in Java Bridge
The Java Bridge makes repeated use of numerous JNI method IDs. We wish to avoid
repeatedly looking up these IDS, so we cache them.
Currently we use Singleton objects to achieve this. However, this seems
inappropriate for several reasons ...
- Requires excessive boilerplate
- Thread safety not required
- Exit cleanup not required
We can avoid using Singleton, without introducing static initializers, by
simply using a static local.
See http://codereview.chromium.org/8659007 for background.
TBR=avi
BUG=105547
Review URL: http://codereview.chromium.org/8769005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112975 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base.gyp')
| -rw-r--r-- | base/base.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/base/base.gyp b/base/base.gyp index f887aad..2ab053d 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -116,6 +116,7 @@ 'test/run_all_unittests.cc', # Tests. + 'android/jni_android_unittest.cc', 'android/scoped_java_ref_unittest.cc', 'at_exit_unittest.cc', 'atomicops_unittest.cc', |