diff options
author | vasilii <vasilii@chromium.org> | 2016-01-15 02:18:45 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-01-15 10:19:30 +0000 |
commit | ac74e7a74cd2e700b1953f0542c09a72c672b1b1 (patch) | |
tree | fadc6afd337641f19b75cc5aff33ca5038c39ef6 /base/base.gyp | |
parent | f795671d8c34bc15ae30a005d38d0a4f5b9fae11 (diff) | |
download | chromium_src-ac74e7a74cd2e700b1953f0542c09a72c672b1b1.zip chromium_src-ac74e7a74cd2e700b1953f0542c09a72c672b1b1.tar.gz chromium_src-ac74e7a74cd2e700b1953f0542c09a72c672b1b1.tar.bz2 |
Revert of [Android] Rework multidex and enable multidex for unit_tests_apk. (patchset #7 id:120001 of https://codereview.chromium.org/1581563003/ )
Reason for revert:
Broke compilation on Android
https://build.chromium.org/p/chromium/builders/Android/builds/50665
FAILED: cd ../../components; python ../build/android/gyp/apk_obfuscate.py --configuration-name Release --android-sdk /b/build/slave/Android/build/src/third_party/android_tools/sdk//platforms/android-23 --android-sdk-tools /b/build/slave/Android/build/src/third_party/android_tools/sdk//build-tools/23.0.1 --android-sdk-jar /b/build/slave/Android/build/src/third_party/android_tools/sdk//platforms/android-23/android.jar "--input-jars-paths=/b/build/slave/Android/build/src/third_party/android_tools/sdk//extras/android/support/multidex/library/libs/android-support-multidex.jar \"../out/Release/lib.java/jsr_305_javalib.jar\" \"../out/Release/lib.java/base_java.jar\" /b/build/slave/Android/build/src/third_party/android_tools/sdk//extras/android/support/annotations/android-support-annotations.jar \"../out/Release/lib.java/cronet_api.jar\" \"../out/Release/lib.java/url_java.jar\" \"../out/Release/lib.java/net_java.jar\" \"../out/Release/lib.java/cronet_java.jar\" \"../out/Release/lib.java/chromium_apk_cronet_perf_test_apk.jar\"" "--proguard-configs=cronet/android/proguard.cfg \"../out/Release/cronet_perf_test_apk/proguard.txt\"" --test-jar-path ../out/Release/test.lib.java/CronetPerfTest.jar --obfuscated-jar-path ../out/Release/cronet_perf_test_apk/obfuscated.jar --proguard-jar-path ../third_party/proguard/lib/proguard.jar --stamp ../out/Release/cronet_perf_test_apk/obfuscate.stamp --testapp --proguard-enabled
Traceback (most recent call last):
File "../build/android/gyp/apk_obfuscate.py", line 185, in <module>
sys.exit(main(sys.argv[1:]))
File "../build/android/gyp/apk_obfuscate.py", line 167, in main
DoProguard(options)
File "../build/android/gyp/apk_obfuscate.py", line 124, in DoProguard
proguard.CheckOutput()
File "/b/build/slave/Android/build/src/build/android/gyp/util/proguard_util.py", line 180, in CheckOutput
stderr_filter=stderr_filter)
File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py", line 162, in CheckOutput
raise CalledProcessError(cwd, args, stdout + stderr)
util.build_utils.CalledProcessError: Command failed: ( cd /b/build/slave/Android/build/src/components; java -jar ../third_party/proguard/lib/proguard.jar -forceprocessing -libraryjars /b/build/slave/Android/build/src/third_party/android_tools/sdk//platforms/android-23/android.jar -injars /b/build/slave/Android/build/src/third_party/android_tools/sdk//extras/android/support/multidex/library/libs/android-support-multidex.jar:../out/Release/lib.java/jsr_305_javalib.jar:../out/Release/lib.java/base_java.jar:/b/build/slave/Android/build/src/third_party/android_tools/sdk//extras/android/support/annotations/android-support-annotations.jar:../out/Release/lib.java/cronet_api.jar:../out/Release/lib.java/url_java.jar:../out/Release/lib.java/net_java.jar:../out/Release/lib.java/cronet_java.jar:../out/Release/lib.java/chromium_apk_cronet_perf_test_apk.jar -include cronet/android/proguard.cfg -include ../out/Release/cronet_perf_test_apk/proguard.txt -outjars ../out/Release/cronet_perf_test_apk/obfuscated.jar -dump ../out/Release/cronet_perf_test_apk/obfuscated.jar.dump -printseeds ../out/Release/cronet_perf_test_apk/obfuscated.jar.seeds -printusage ../out/Release/cronet_perf_test_apk/obfuscated.jar.usage -printmapping ../out/Release/cronet_perf_test_apk/obfuscated.jar.mapping )
Warning: org.chromium.base.multidex.ChromiumMultiDexInstaller: can't find referenced class org.chromium.base.multidex.ChromiumMultiDex
Warning: org.chromium.base.multidex.ChromiumMultiDexInstaller: can't find referenced class org.chromium.base.multidex.ChromiumMultiDex
Warning: there were 2 unresolved references to classes or interfaces.
You may need to specify additional library jars (using '-libraryjars').
Error: Please correct the above warnings first.
Original issue's description:
> [Android] Rework multidex and enable multidex for unit_tests_apk.
>
> This allows multidex to be used in release builds.
>
> BUG=272790
>
> Committed: https://crrev.com/f743bef34d49987c0f1f69e2f0bb6cb8beb03bf5
> Cr-Commit-Position: refs/heads/master@{#369715}
TBR=phajdan.jr@chromium.org,agrieve@chromium.org,dpranke@chromium.org,thakis@chromium.org,yfriedman@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=272790
Review URL: https://codereview.chromium.org/1587253003
Cr-Commit-Position: refs/heads/master@{#369717}
Diffstat (limited to 'base/base.gyp')
-rw-r--r-- | base/base.gyp | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/base/base.gyp b/base/base.gyp index 94a1d49..dc484f4 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -1489,6 +1489,9 @@ 'variables': { 'package_name': 'org/chromium/base/multidex', 'template_deps': [], + 'additional_gcc_preprocess_options': [ + '--defines', 'MULTIDEX_CONFIGURATION_<(CONFIGURATION_NAME)', + ], }, 'includes': ['../build/android/java_cpp_template.gypi'], }, @@ -1507,10 +1510,7 @@ 'type': 'none', 'variables': { 'java_in_dir': 'android/java', - 'jar_excluded_classes': [ - '*/ChromiumMultiDex.class', - '*/NativeLibraries.class', - ], + 'jar_excluded_classes': [ '*/NativeLibraries.class' ], }, 'dependencies': [ 'base_java_application_state', @@ -1522,11 +1522,6 @@ '../third_party/android_tools/android_tools.gyp:android_support_multidex_javalib', '../third_party/jsr-305/jsr-305.gyp:jsr_305_javalib', ], - 'all_dependent_settings': { - 'variables': { - 'generate_multidex_config': 1, - }, - }, 'includes': [ '../build/java.gypi' ], }, { @@ -1588,7 +1583,6 @@ 'target_name': 'base_junit_test_support', 'type': 'none', 'dependencies': [ - 'base_multidex_gen', '../testing/android/junit/junit_test.gyp:junit_test_support', '../third_party/android_tools/android_tools.gyp:android_support_multidex_javalib', ], |