summaryrefslogtreecommitdiffstats
path: root/base/base.gyp
diff options
context:
space:
mode:
authorpasko <pasko@chromium.org>2015-04-27 08:55:18 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-27 15:55:20 +0000
commite1ceecf5545568261956de95fda59270a91d4ef0 (patch)
treebdc6da55bb76521c35c3388b42675f4ac5c1d121 /base/base.gyp
parent50b83c1a8d3fe0be4ee0ab62c33c4767981d436a (diff)
downloadchromium_src-e1ceecf5545568261956de95fda59270a91d4ef0.zip
chromium_src-e1ceecf5545568261956de95fda59270a91d4ef0.tar.gz
chromium_src-e1ceecf5545568261956de95fda59270a91d4ef0.tar.bz2
Revert "Intercept base::File Open/Close"
This reverts commit 45a0dc0b75b52e026eb15526ef441edc5dbe9ba5. > Intercept base::File Open/Close > > When a file descriptor is opened by the base::File, all calls to close(3) from > the same dynamic library will hit a CHECK unless they are made from a > whitelist of callsites belonging to base::File. > > There is a handy protect_file_posix.gypi introduced to make it easy to enable > on Chrome-for-Android. > > This 'linker magic' is somewhat crazy, so: > 1. it will be *removed *when crbug.com/424562 is fixed > 2. it should only be used by a whitelist of binaries/libraries (in the > opensource part: libchromeshell only) > > BUG=424562 > > Review URL: https://codereview.chromium.org/676873004 > > Cr-Commit-Position: refs/heads/master@{#304592} Reason: crashes are not numerous, not much sense to fix, some explanations found elsewhere. BUG=424562 Review URL: https://codereview.chromium.org/1101723004 Cr-Commit-Position: refs/heads/master@{#327051}
Diffstat (limited to 'base/base.gyp')
-rw-r--r--base/base.gyp18
1 files changed, 0 insertions, 18 deletions
diff --git a/base/base.gyp b/base/base.gyp
index 2543156..e9d3e81 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -376,24 +376,6 @@
],
},
{
- # TODO(pasko): Remove this target when crbug.com/424562 is fixed.
- # GN: //base:protect_file_posix
- 'target_name': 'protect_file_posix',
- 'conditions': [
- ['os_posix == 1', {
- 'type': 'static_library',
- 'dependencies': [
- 'base',
- ],
- 'sources': [
- 'files/protect_file_posix.cc',
- ],
- }, {
- 'type': 'none',
- }],
- ],
- },
- {
'target_name': 'base_prefs_test_support',
'type': 'static_library',
'dependencies': [