diff options
| author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 00:09:54 +0000 |
|---|---|---|
| committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 00:09:54 +0000 |
| commit | 307175443726a8a2a23b99371900812bb020f9a0 (patch) | |
| tree | eb5e8f92dee5617aa57f24a88974c76df6bfd43b /base/base.gypi | |
| parent | 930c7473b7ee905ceec94850034ce4e6fa441ca1 (diff) | |
| download | chromium_src-307175443726a8a2a23b99371900812bb020f9a0.zip chromium_src-307175443726a8a2a23b99371900812bb020f9a0.tar.gz chromium_src-307175443726a8a2a23b99371900812bb020f9a0.tar.bz2 | |
Speculative fix for crash in DOMUIThumbnailSource.
DOMUIThumbnailSource objects are deleted on the IO thread, while they are used
on the UI thread. The DataSource documentation says that they should not live
on the IO thread, but for almost all DataSources, the only reference held is
the one by ChromeURLDataManager, which lives on the IO thread. Since I had a racy
stack where the object was being used on the UI thread while its destructor was
running on the IO thread, forcing destruction on the UI thread should fix
the crash.
Pretty much everything but changing the templated base class of DataSource to
always DeleteOnUIThread is my usual cleanup.
BUG=34115
TEST=none
Review URL: http://codereview.chromium.org/3061009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53873 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/base.gypi')
| -rw-r--r-- | base/base.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/base/base.gypi b/base/base.gypi index 2553ab5..cad0256 100644 --- a/base/base.gypi +++ b/base/base.gypi @@ -176,6 +176,7 @@ 'raw_scoped_refptr_mismatch_checker.h', 'ref_counted.cc', 'ref_counted.h', + 'ref_counted_memory.cc', 'ref_counted_memory.h', 'registry.cc', 'registry.h', |