diff options
| author | wittman <wittman@chromium.org> | 2015-08-23 17:42:51 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-24 00:43:29 +0000 |
| commit | 863f84165da958298516064732d4d5b62ad7eb59 (patch) | |
| tree | 819e9a33a10ab2e6b969a4aeec58e095992090a8 /base/base.gypi | |
| parent | 3d0c27d8a3959f3962b1e1407e3a347b4e46034d (diff) | |
| download | chromium_src-863f84165da958298516064732d4d5b62ad7eb59.zip chromium_src-863f84165da958298516064732d4d5b62ad7eb59.tar.gz chromium_src-863f84165da958298516064732d4d5b62ad7eb59.tar.bz2 | |
Stack sampling profiler: re-enable stack collection for stacks terminated by leaf functions
Collect the 5% of leaf-terminated stacks that we're currently missing.
Avoids crashes we saw previously on unwinding frames in injected third
party modules with functions not adhering to the Microsoft x64 calling
conventions, by blacklisting leaf unwinding for these modules when we
first see a bad frame.
With this change there's still a very small possibility of crashing if a
stack happens to start with one of the bad third party functions. This
change will allow us to collect crash data on this case and inform a
decision about appropriate heuristics to deal with it.
BUG=516402
Review URL: https://codereview.chromium.org/1263403002
Cr-Commit-Position: refs/heads/master@{#345012}
Diffstat (limited to 'base/base.gypi')
| -rw-r--r-- | base/base.gypi | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/base/base.gypi b/base/base.gypi index ef04846..39727098 100644 --- a/base/base.gypi +++ b/base/base.gypi @@ -939,6 +939,10 @@ 'include_dirs': [ '<(DEPTH)/third_party/wtl/include', ], + 'sources': [ + 'profiler/win32_stack_frame_unwinder.cc', + 'profiler/win32_stack_frame_unwinder.h', + ], 'sources!': [ 'files/file_path_watcher_fsevents.cc', 'files/file_path_watcher_fsevents.h', |