diff options
| author | icoolidge <icoolidge@chromium.org> | 2015-04-01 00:03:22 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-01 07:04:08 +0000 |
| commit | 82cb6b003c8e20e4a8386bf8698980bb4981d434 (patch) | |
| tree | 3e67ec25415c3713b07e1d6154d340ac5f1764f9 /base/base_unittests.isolate | |
| parent | 6119a59cd027dc95156d29c3d922d673e55ad1f5 (diff) | |
| download | chromium_src-82cb6b003c8e20e4a8386bf8698980bb4981d434.zip chromium_src-82cb6b003c8e20e4a8386bf8698980bb4981d434.tar.gz chromium_src-82cb6b003c8e20e4a8386bf8698980bb4981d434.tar.bz2 | |
Fix OutOfMemoryDeathTest.ViaSharedLibraries.
This test was invalid on modern glibc:
asprintf errors EOVERFLOW without attempting an allocation
when the size is at least INT_MAX - 32. INT_MAX - 33 is the
largest size that can attempt to trigger allocation failure,
and will not necessarily accomplish that on some systems.
Create a library that is specified to wrap malloc trivially,
to accomplish the goal of the test without external dependencies
or inconsistently implemented behavior.
BUG=428211
Review URL: https://codereview.chromium.org/878473002
Cr-Commit-Position: refs/heads/master@{#323197}
Diffstat (limited to 'base/base_unittests.isolate')
| -rw-r--r-- | base/base_unittests.isolate | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/base/base_unittests.isolate b/base/base_unittests.isolate index e329152..b1c270c 100644 --- a/base/base_unittests.isolate +++ b/base/base_unittests.isolate @@ -50,6 +50,13 @@ 'read_only': 1, }, }], + ['OS=="linux"', { + 'variables': { + 'files': [ + '<(PRODUCT_DIR)/lib/libmalloc_wrapper.so', + ], + }, + }], ['OS=="mac" and asan==1 and fastbuild==0', { 'variables': { 'files': [ |