diff options
| author | glider <glider@chromium.org> | 2015-02-06 09:42:27 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-06 17:43:30 +0000 |
| commit | 9d9193404a307ba7cf79db460a0f988bc349bc4e (patch) | |
| tree | 777b6f6f18ece035c45a965fa87d8d0a1f58f935 /base/base_unittests.isolate | |
| parent | 1490217011f83c5b46253d24d913e9bfb98f8005 (diff) | |
| download | chromium_src-9d9193404a307ba7cf79db460a0f988bc349bc4e.zip chromium_src-9d9193404a307ba7cf79db460a0f988bc349bc4e.tar.gz chromium_src-9d9193404a307ba7cf79db460a0f988bc349bc4e.tar.bz2 | |
Fix report symbolization on swarming bots.
According to issue 444835 there were at least two problems with debug info on
the swarming bots:
- the .dSYM bundles for the test binaries and other applications weren't
uploaded to swarming servers;
- for some binaries (e.g. Chromium Framework) their names were replaced with
SHA-1 hashes that confused llvm-symbolizer and made finding the .dSYM bundles
impossible.
This CL adds the necessary .dSYM paths to .isolate files for the tests
currently being ran on swarming bots (for other tests their .dSYM paths will be
added as needed).
It also extends tools/valgrind/asan/asan_symbolize.py with a binary name filter
that replaces the hashes with the corresponding file names in the product
directory.
BUG=444835
R=earthdok@chromium.org,maruel@chromium.org,csharp@chromium.org
Review URL: https://codereview.chromium.org/859293002
Cr-Commit-Position: refs/heads/master@{#315059}
Diffstat (limited to 'base/base_unittests.isolate')
| -rw-r--r-- | base/base_unittests.isolate | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/base/base_unittests.isolate b/base/base_unittests.isolate index fca76d5..0822b24 100644 --- a/base/base_unittests.isolate +++ b/base/base_unittests.isolate @@ -58,6 +58,13 @@ ], }, }], + ['OS=="mac" and asan==1', { + 'variables': { + 'files': [ + '<(PRODUCT_DIR)/base_unittests.dSYM/', + ], + }, + }], ['OS=="win" and (fastbuild==0 or fastbuild==1)', { 'variables': { 'files': [ |