summaryrefslogtreecommitdiffstats
path: root/base/check_example.cc
diff options
context:
space:
mode:
authorthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-21 16:04:50 +0000
committerthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-21 16:04:50 +0000
commit7de8404f117520baf2d45cf248c5450fecbb051f (patch)
treed59b102f318edc94c06e44201696578ebc05a966 /base/check_example.cc
parent0c6601903f547785adadfbed4856b4fc039d5599 (diff)
downloadchromium_src-7de8404f117520baf2d45cf248c5450fecbb051f.zip
chromium_src-7de8404f117520baf2d45cf248c5450fecbb051f.tar.gz
chromium_src-7de8404f117520baf2d45cf248c5450fecbb051f.tar.bz2
Make IPC_MESSAGE_EXPORT more robust.
Currently, files that want to export ipc messages currently do #undef IPC_MESSAGE_EXPORT #define IPC_MESSAGE_EXPORT CONTENT_EXPORT at the top, and files that don't want to export ipc messages just do nothing. This is problematic if a cc file does #include "exported_messages.h" #include "not_exported_messages.h" because the second header file picks up the #define from the first file and declares all its messages as exported. In other translation units, where not_exported_messages.h is #included without another header above it, the messages will get default visibility – so the same class ends up with different visibilities in different translation units. Instead, let ipc_message_macros.h #undef IPC_MESSAGE_EXPORT outside of the include guard, so that all files that don't set the define see it as defined to nothing. (Idea from jam@) Also disable about:ipc in the component build, since ipc logging adds a dependency from chrome on all ipc message classes, so they would all have to be exported. BUG=90078 TEST=No linker errors about IPC messages when doing components build on mac. (Other linker errors remain for now.) TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122689 Review URL: http://codereview.chromium.org/9425006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122828 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/check_example.cc')
0 files changed, 0 insertions, 0 deletions