diff options
author | dalecurtis <dalecurtis@chromium.org> | 2015-10-23 14:20:44 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-10-23 21:21:34 +0000 |
commit | 5106549d342a95e4296630c75648f45313ee2ed8 (patch) | |
tree | ac848b90846ae77dab1523f9aefbf84d728a7a49 /base/environment.h | |
parent | ccb7824284975a271967334f86b4fc7a17378de5 (diff) | |
download | chromium_src-5106549d342a95e4296630c75648f45313ee2ed8.zip chromium_src-5106549d342a95e4296630c75648f45313ee2ed8.tar.gz chromium_src-5106549d342a95e4296630c75648f45313ee2ed8.tar.bz2 |
Revert of Refactor screen_dimmer to share code and shrink Shell interface. (patchset #8 id:160001 of https://codereview.chromium.org/1415033002/ )
Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=547178
Original issue's description:
> Refactor screen_dimmer to share code and shrink Shell interface.
> DimWindow : a window that implement dimming. You can just add it to container and let it handle its state.
> ScreenDimmer : an object that keeps the state consistent across multiple root windows. It's owned by the primary container and gets destroyed when the container is destroyed.
>
> * Added wm::SetWindowVisiblityChangesAnimated to ui/wm/core/visibility_controller.h, to animate individual window's visibility change. The dim layer can be added to root (or any other container), and we probably don't want to enable animation for all children in such case.
>
> * Use solid color layer for modal background. it's more efficient.
>
> BUG=478438
> TEST=updated existing screen_dimmer_unittest, VisibilityControllerTest.SetWindowVisibilityChangesAnimated
>
> Committed: https://crrev.com/cefa50b01ed3d5d592f66ab56b5b3934b5ad9070
> Cr-Commit-Position: refs/heads/master@{#355468}
TBR=mukai@chromium.org,sky@chromium.org,oshima@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478438
Review URL: https://codereview.chromium.org/1421183002
Cr-Commit-Position: refs/heads/master@{#355886}
Diffstat (limited to 'base/environment.h')
0 files changed, 0 insertions, 0 deletions