diff options
author | sorin@chromium.org <sorin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-13 23:02:18 +0000 |
---|---|---|
committer | sorin@chromium.org <sorin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-13 23:02:18 +0000 |
commit | d7285fc3158696fedf1c1e337c0680b71669e438 (patch) | |
tree | 5b09160abe4a70d272d88ad377a104aeeaacf4f9 /base/i18n | |
parent | 83e4b949eb8d2fb38e18ac3381189323f8c539d5 (diff) | |
download | chromium_src-d7285fc3158696fedf1c1e337c0680b71669e438.zip chromium_src-d7285fc3158696fedf1c1e337c0680b71669e438.tar.gz chromium_src-d7285fc3158696fedf1c1e337c0680b71669e438.tar.bz2 |
Revert 277111 "Roll ICU to icu52"
It breaks a bunch of bots with a compile time error
../out/Release/gen/tc_pnacl_newlib/lib/libicuuc_nacl.a: error: undefined reference to 'icudt52_dat'
For example: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/7531
> Roll ICU to icu52
>
> The ICU update does the following among other things:
> - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG
> encoding spec.
> - Add CP866
> - Add far better/more extensive support for plural, format, etc
> - Numerous locale data update
> - Khmer/Lao line/word-breaking support
> - More compact Chinese/Japanese dictionary (now a part of the upstream
> instead of our local patch)
> - Better plural support that we plan to use right away.
>
> - Update icu/BUILD.gn : file list update, new defines, etc.
> - Update tests
> a. icu_string_conversions_unittests : drop iscii (nobody uses it) and
> remove JIS X 212 code points from the round-trip test
> b. l10n_util_unittests: Display names for zh-*.
> c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change).
> d. Update Expected results in file_manager_browsertest/test_util.js
> (see http://crbug.com/383930)
> - Update SpellcheckerWordIterator
> a. Add U+0027 back to MidNumLet
> b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based
> word-breaking.
> - l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino)
> - Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full
> has 'at' before time, which is not handled by Date.parse()
> - update license.py because we don't have a separate Chinese/Japanese
> dictionary any more. It's now a part of ICU
>
> BUG=132145,277023,136148,360433,364072
> TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*,
> browser_tests (encoding related, Iden*verifyGet*),
> unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*,
> layout tests (encoding, date/calendar, line breaking, and others),
> build 'base_i18n_nacl', GN build bots.
>
> Review URL: https://codereview.chromium.org/265613002
TBR=jshin@chromium.org
Review URL: https://codereview.chromium.org/336793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277117 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/i18n')
-rw-r--r-- | base/i18n/icu_string_conversions_unittest.cc | 18 |
1 files changed, 16 insertions, 2 deletions
diff --git a/base/i18n/icu_string_conversions_unittest.cc b/base/i18n/icu_string_conversions_unittest.cc index 04c3b92..62e055e 100644 --- a/base/i18n/icu_string_conversions_unittest.cc +++ b/base/i18n/icu_string_conversions_unittest.cc @@ -186,6 +186,13 @@ static const struct { true, L"\x05E9\x05C1\x05B8\x05DC\x05D5\x05B9\x05DD", NULL}, + // Hindi Devanagari (ISCII) + {"iscii-dev", + "\xEF\x42" "\xC6\xCC\xD7\xE8\xB3\xDA\xCF", + OnStringConversionError::FAIL, + true, + L"\x0928\x092E\x0938\x094D\x0915\x093E\x0930", + NULL}, // Korean (EUC) {"euc-kr", "\xBE\xC8\xB3\xE7\xC7\xCF\xBC\xBC\xBF\xE4", @@ -195,10 +202,10 @@ static const struct { NULL}, // Japanese (EUC) {"euc-jp", - "\xA4\xB3\xA4\xF3\xA4\xCB\xA4\xC1\xA4\xCF\xB0\xEC\x8E\xA6", + "\xA4\xB3\xA4\xF3\xA4\xCB\xA4\xC1\xA4\xCF\xB0\xEC\x8F\xB0\xA1\x8E\xA6", OnStringConversionError::FAIL, true, - L"\x3053\x3093\x306B\x3061\x306F\x4E00\xFF66", + L"\x3053\x3093\x306B\x3061\x306F\x4E00\x4E02\xFF66", NULL}, // Japanese (ISO-2022) {"iso-2022-jp", @@ -231,6 +238,13 @@ static const struct { L"\x0E2A\x0E27\x0E31\x0E2A\x0E14\x0E35" L"\x0E04\x0E23\x0e31\x0E1A", NULL}, + // Empty text + {"iscii-dev", + "", + OnStringConversionError::FAIL, + true, + L"", + NULL}, }; TEST(ICUStringConversionsTest, ConvertBetweenCodepageAndWide) { |