Correct iOS build for latest Xcode beta.

- NSObject's NS_DESIGNATED_INITIALIZER -init method requires
   an -init NS_UNAVAILABLE implementation.
- Correct nonnull API usage.
- Cast to NSInteger for comparisons with NSNotFound.
- Account for dylib -> tbd change in latest Xcode.

BUG=498581, 498825, 498841

Review URL: https://codereview.chromium.org/1171203004

Cr-Commit-Position: refs/heads/master@{#333756}

1 files changed, 7 insertions, 2 deletions

diff --git a/base/ios/crb_protocol_observers_unittest.mm b/base/ios/crb_protocol_observers_unittest.mm
index 5f11051..b8cf423 100644
--- a/base/ios/crb_protocol_observers_unittest.mm
+++ b/base/ios/crb_protocol_observers_unittest.mm
@@ -4,6 +4,7 @@
 
 #import "base/ios/crb_protocol_observers.h"
 #include "base/ios/weak_nsobject.h"
+#include "base/logging.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/mac/scoped_nsobject.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -36,10 +37,9 @@
 @end
 
 @interface TestMutateObserver : TestCompleteObserver
-
 - (instancetype)initWithObserver:(CRBProtocolObservers*)observer
     NS_DESIGNATED_INITIALIZER;
-
+- (instancetype)init NS_UNAVAILABLE;
 @end
 
 namespace {
@@ -266,6 +266,11 @@ TEST_F(CRBProtocolObserversTest, NestedMutateObservers) {
   return self;
 }
 
+- (instancetype)init {
+  NOTREACHED();
+  return nil;
+}
+
 - (void)mutateByAddingObserver:(id<TestObserver>)observer {
   [_observers addObserver:observer];
 }