summaryrefslogtreecommitdiffstats
path: root/base/json/json_value_converter_unittest.cc
diff options
context:
space:
mode:
authormukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-26 19:32:36 +0000
committermukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-26 19:32:36 +0000
commit50fa6f92efd0aceae9dbe689b3b216d003b095a7 (patch)
treea2a7a13606510b69d46aa6d6e1bf7c4f483aacfd /base/json/json_value_converter_unittest.cc
parent15b1224dc8e1918d0aa534676e65c802617a739b (diff)
downloadchromium_src-50fa6f92efd0aceae9dbe689b3b216d003b095a7.zip
chromium_src-50fa6f92efd0aceae9dbe689b3b216d003b095a7.tar.gz
chromium_src-50fa6f92efd0aceae9dbe689b3b216d003b095a7.tar.bz2
Fix a potential memory leak bug.
BUG= TEST= Review URL: http://codereview.chromium.org/9113075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/json/json_value_converter_unittest.cc')
-rw-r--r--base/json/json_value_converter_unittest.cc17
1 files changed, 17 insertions, 0 deletions
diff --git a/base/json/json_value_converter_unittest.cc b/base/json/json_value_converter_unittest.cc
index d23a1e9..b81a52c 100644
--- a/base/json/json_value_converter_unittest.cc
+++ b/base/json/json_value_converter_unittest.cc
@@ -193,4 +193,21 @@ TEST(JSONValueConverterTest, EnumParserFails) {
// No check the values as mentioned above.
}
+TEST(JSONValueConverterTest, RepeatedValueErrorInTheMiddle) {
+ const char normal_data[] =
+ "{\n"
+ " \"foo\": 1,\n"
+ " \"bar\": \"bar\",\n"
+ " \"baz\": true,\n"
+ " \"simple_enum\": \"baz\","
+ " \"ints\": [1, false]"
+ "}\n";
+
+ scoped_ptr<Value> value(base::JSONReader::Read(normal_data, false));
+ SimpleMessage message;
+ base::JSONValueConverter<SimpleMessage> converter;
+ EXPECT_FALSE(converter.Convert(*value.get(), &message));
+ // No check the values as mentioned above.
+}
+
} // namespace base