summaryrefslogtreecommitdiffstats
path: root/base/logging_unittest.cc
diff options
context:
space:
mode:
authorviettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-17 12:04:23 +0000
committerviettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-17 12:04:23 +0000
commitf2c0549ecf5ae4f682059fce947567aad107ecb3 (patch)
treef4b836c3e97babb3eebd8d2cbc7f475abf2390be /base/logging_unittest.cc
parent9a68fa2d4ef805aaceb88890b753345c99e57881 (diff)
downloadchromium_src-f2c0549ecf5ae4f682059fce947567aad107ecb3.zip
chromium_src-f2c0549ecf5ae4f682059fce947567aad107ecb3.tar.gz
chromium_src-f2c0549ecf5ae4f682059fce947567aad107ecb3.tar.bz2
Remove the LOG_ERROR_REPORT log severity level.
It's been unused since r255987 (which removed the --enable-dcheck flag, among other things). Also remove the --silent-dump-on-dcheck flag (because now there's not even code that pretends to use it). R=brettw@chromium.org,sky@chromium.org BUG=352378 Review URL: https://codereview.chromium.org/331143007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277736 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging_unittest.cc')
-rw-r--r--base/logging_unittest.cc24
1 files changed, 1 insertions, 23 deletions
diff --git a/base/logging_unittest.cc b/base/logging_unittest.cc
index 44a1be3..f823d6e 100644
--- a/base/logging_unittest.cc
+++ b/base/logging_unittest.cc
@@ -32,7 +32,6 @@ class LogStateSaver {
~LogStateSaver() {
SetMinLogLevel(old_min_log_level_);
SetLogAssertHandler(NULL);
- SetLogReportHandler(NULL);
log_sink_call_count = 0;
}
@@ -96,7 +95,6 @@ TEST_F(LoggingTest, LogIsOn) {
EXPECT_TRUE(LOG_IS_ON(INFO));
EXPECT_TRUE(LOG_IS_ON(WARNING));
EXPECT_TRUE(LOG_IS_ON(ERROR));
- EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
EXPECT_TRUE(LOG_IS_ON(FATAL));
EXPECT_TRUE(LOG_IS_ON(DFATAL));
@@ -104,7 +102,6 @@ TEST_F(LoggingTest, LogIsOn) {
EXPECT_FALSE(LOG_IS_ON(INFO));
EXPECT_TRUE(LOG_IS_ON(WARNING));
EXPECT_TRUE(LOG_IS_ON(ERROR));
- EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
EXPECT_TRUE(LOG_IS_ON(FATAL));
EXPECT_TRUE(LOG_IS_ON(DFATAL));
@@ -112,33 +109,14 @@ TEST_F(LoggingTest, LogIsOn) {
EXPECT_FALSE(LOG_IS_ON(INFO));
EXPECT_FALSE(LOG_IS_ON(WARNING));
EXPECT_TRUE(LOG_IS_ON(ERROR));
- EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
EXPECT_TRUE(LOG_IS_ON(FATAL));
EXPECT_TRUE(LOG_IS_ON(DFATAL));
- SetMinLogLevel(LOG_ERROR_REPORT);
- EXPECT_FALSE(LOG_IS_ON(INFO));
- EXPECT_FALSE(LOG_IS_ON(WARNING));
- EXPECT_FALSE(LOG_IS_ON(ERROR));
- EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
- EXPECT_TRUE(LOG_IS_ON(FATAL));
- EXPECT_TRUE(kDfatalIsFatal == LOG_IS_ON(DFATAL));
-
- // LOG_IS_ON(ERROR_REPORT) should always be true.
- SetMinLogLevel(LOG_FATAL);
- EXPECT_FALSE(LOG_IS_ON(INFO));
- EXPECT_FALSE(LOG_IS_ON(WARNING));
- EXPECT_FALSE(LOG_IS_ON(ERROR));
- EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
- EXPECT_TRUE(LOG_IS_ON(FATAL));
- EXPECT_TRUE(kDfatalIsFatal == LOG_IS_ON(DFATAL));
-
- // So should LOG_IS_ON(FATAL).
+ // LOG_IS_ON(FATAL) should always be true.
SetMinLogLevel(LOG_FATAL + 1);
EXPECT_FALSE(LOG_IS_ON(INFO));
EXPECT_FALSE(LOG_IS_ON(WARNING));
EXPECT_FALSE(LOG_IS_ON(ERROR));
- EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
EXPECT_TRUE(LOG_IS_ON(FATAL));
EXPECT_TRUE(kDfatalIsFatal == LOG_IS_ON(DFATAL));
}