diff options
| author | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-28 18:12:04 +0000 |
|---|---|---|
| committer | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-28 18:12:04 +0000 |
| commit | c1e77f1abf570f007abaf380a4fe49e61de1895d (patch) | |
| tree | d0cf1201a8d2367d8a9457c6e371f99aa6027954 /base/mac | |
| parent | 8d678efa788dcdfc646daa1325f8949e18754f6d (diff) | |
| download | chromium_src-c1e77f1abf570f007abaf380a4fe49e61de1895d.zip chromium_src-c1e77f1abf570f007abaf380a4fe49e61de1895d.tar.gz chromium_src-c1e77f1abf570f007abaf380a4fe49e61de1895d.tar.bz2 | |
Flash: Don't lose references to the Graphics3D from the VideoDecoder.
When the Flash VideoDecoder is destroyed, it needs to drop the reference
it holds on the Graphics3D object.
Currently, the Destroy() method erases the id for the Graphics3D object
before trying to drop its reference, making the drop a no-op and leaking
the reference.
Also, if the PPB_VideoDecoder_Impl object fails to initialize and create
a platform_video_decoder_, it still holds onto its reference to the
Graphics3D since it does not call Destroy() even though it called
InitCommon() on the PPB_VideoDecoder_Shared base class.
Lastly, when the plugin proxy's VideoDecoder class is destroyed, it
should ensure that the base class' Destroy() has been called so that
its reference is not leaked.
BUG=chrome-os-partner:18331
Review URL: https://chromiumcodereview.appspot.com/13123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191176 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/mac')
0 files changed, 0 insertions, 0 deletions