Several small changes to base::SharedMemory.

- Removed ShallowCopyHandle().
- Renamed DeepCopyHandle() -> DuplicateHandle().
- Changed the signature of DuplicateHandle() to not accept
  |clean_up_resources_on_destruction|. (The flag has no effect on
  base::SharedMemory).
- Defined DuplicateHandle() on Win, POSIX, and Nacl.

BUG=466437

Review URL: https://codereview.chromium.org/1160503004

Cr-Commit-Position: refs/heads/master@{#332506}

1 files changed, 2 insertions, 11 deletions

diff --git a/base/memory/shared_memory_posix.cc b/base/memory/shared_memory_posix.cc
index 613c26f..430ae0e 100644
--- a/base/memory/shared_memory_posix.cc
+++ b/base/memory/shared_memory_posix.cc
@@ -247,21 +247,12 @@ size_t SharedMemory::GetHandleLimit() {
 }
 
 // static
-SharedMemoryHandle SharedMemory::ShallowCopyHandle(
+SharedMemoryHandle SharedMemory::DuplicateHandle(
     const SharedMemoryHandle& handle) {
-  SharedMemoryHandle new_handle = handle;
-  new_handle.auto_close = false;
-  return new_handle;
-}
-
-// static
-SharedMemoryHandle SharedMemory::DeepCopyHandle(
-    const SharedMemoryHandle& handle,
-    bool clean_up_resources_on_destruction) {
   int duped_handle = HANDLE_EINTR(dup(handle.fd));
   if (duped_handle < 0)
     return base::SharedMemory::NULLHandle();
-  return base::FileDescriptor(duped_handle, clean_up_resources_on_destruction);
+  return base::FileDescriptor(duped_handle, true);
 }
 
 // static