diff options
| author | acleung@chromium.org <acleung@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-10 09:33:30 +0000 |
|---|---|---|
| committer | acleung@chromium.org <acleung@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-10 09:33:30 +0000 |
| commit | e76ddeb0e5ef9863fe10f5c1aea9da8f975bce71 (patch) | |
| tree | 2952bec07c34713826223012dc25027ece8bdbb6 /base/metrics | |
| parent | 5184fb77262c6fe89eacb15720c9c1899bf2a27c (diff) | |
| download | chromium_src-e76ddeb0e5ef9863fe10f5c1aea9da8f975bce71.zip chromium_src-e76ddeb0e5ef9863fe10f5c1aea9da8f975bce71.tar.gz chromium_src-e76ddeb0e5ef9863fe10f5c1aea9da8f975bce71.tar.bz2 | |
Delete Histogram.SharedRange.* suggested.
See comments in the review.
BUG=168662
Review URL: https://chromiumcodereview.appspot.com/14731009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199437 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/metrics')
| -rw-r--r-- | base/metrics/statistics_recorder.cc | 55 | ||||
| -rw-r--r-- | base/metrics/statistics_recorder.h | 5 |
2 files changed, 0 insertions, 60 deletions
diff --git a/base/metrics/statistics_recorder.cc b/base/metrics/statistics_recorder.cc index 3176f26..2042ac4 100644 --- a/base/metrics/statistics_recorder.cc +++ b/base/metrics/statistics_recorder.cc @@ -23,13 +23,6 @@ base::LazyInstance<base::StatisticsRecorder>::Leaky g_statistics_recorder_ = namespace base { -// Collect the number of histograms created. -static uint32 number_of_histograms_ = 0; -// Collect the number of vectors saved because of caching ranges. -static uint32 number_of_vectors_saved_ = 0; -// Collect the number of ranges_ elements saved because of caching ranges. -static size_t saved_ranges_size_ = 0; - // static void StatisticsRecorder::Initialize() { // Ensure that an instance of the StatisticsRecorder object is created. @@ -70,7 +63,6 @@ HistogramBase* StatisticsRecorder::RegisterOrDeleteDuplicate( if (histograms_->end() == it) { (*histograms_)[name] = histogram; ANNOTATE_LEAKING_OBJECT_PTR(histogram); // see crbug.com/79322 - ++number_of_histograms_; histogram_to_return = histogram; } else if (histogram == it->second) { // The histogram was registered before. @@ -123,8 +115,6 @@ const BucketRanges* StatisticsRecorder::RegisterOrDeleteDuplicateRanges( if (existing_ranges == ranges) { return ranges; } else { - ++number_of_vectors_saved_; - saved_ranges_size_ += ranges->size(); ranges_deleter.reset(ranges); return existing_ranges; } @@ -137,51 +127,6 @@ const BucketRanges* StatisticsRecorder::RegisterOrDeleteDuplicateRanges( } // static -void StatisticsRecorder::CollectHistogramStats(const std::string& suffix) { - static int uma_upload_attempt = 0; - ++uma_upload_attempt; - if (uma_upload_attempt == 1) { - UMA_HISTOGRAM_COUNTS_10000( - "Histogram.SharedRange.Count.FirstUpload." + suffix, - number_of_histograms_); - UMA_HISTOGRAM_COUNTS_10000( - "Histogram.SharedRange.RangesSaved.FirstUpload." + suffix, - number_of_vectors_saved_); - UMA_HISTOGRAM_COUNTS( - "Histogram.SharedRange.ElementsSaved.FirstUpload." + suffix, - static_cast<int>(saved_ranges_size_)); - number_of_histograms_ = 0; - number_of_vectors_saved_ = 0; - saved_ranges_size_ = 0; - return; - } - if (uma_upload_attempt == 2) { - UMA_HISTOGRAM_COUNTS_10000( - "Histogram.SharedRange.Count.SecondUpload." + suffix, - number_of_histograms_); - UMA_HISTOGRAM_COUNTS_10000( - "Histogram.SharedRange.RangesSaved.SecondUpload." + suffix, - number_of_vectors_saved_); - UMA_HISTOGRAM_COUNTS( - "Histogram.SharedRange.ElementsSaved.SecondUpload." + suffix, - static_cast<int>(saved_ranges_size_)); - number_of_histograms_ = 0; - number_of_vectors_saved_ = 0; - saved_ranges_size_ = 0; - return; - } - UMA_HISTOGRAM_COUNTS_10000( - "Histogram.SharedRange.Count.RestOfUploads." + suffix, - number_of_histograms_); - UMA_HISTOGRAM_COUNTS_10000( - "Histogram.SharedRange.RangesSaved.RestOfUploads." + suffix, - number_of_vectors_saved_); - UMA_HISTOGRAM_COUNTS( - "Histogram.SharedRange.ElementsSaved.RestOfUploads." + suffix, - static_cast<int>(saved_ranges_size_)); -} - -// static void StatisticsRecorder::WriteHTMLGraph(const std::string& query, std::string* output) { if (!IsActive()) diff --git a/base/metrics/statistics_recorder.h b/base/metrics/statistics_recorder.h index c7c0983a..9a55225 100644 --- a/base/metrics/statistics_recorder.h +++ b/base/metrics/statistics_recorder.h @@ -49,11 +49,6 @@ class BASE_EXPORT StatisticsRecorder { static const BucketRanges* RegisterOrDeleteDuplicateRanges( const BucketRanges* ranges); - // Method for collecting stats about histograms created in browser and - // renderer processes. |suffix| is appended to histogram names. |suffix| could - // be either browser or renderer. - static void CollectHistogramStats(const std::string& suffix); - // Methods for printing histograms. Only histograms which have query as // a substring are written to output (an empty string will process all // registered histograms). |