diff options
| author | falken@chromium.org <falken@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-02 05:39:01 +0000 |
|---|---|---|
| committer | falken@chromium.org <falken@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-02 05:39:01 +0000 |
| commit | f87c00c2e047e67864a2b66b26659d2a86c4a112 (patch) | |
| tree | c9b9f70af09ec17da9e1ddfce85f75c690f57f7e /base/path_service.h | |
| parent | 1ae2e642249ed8eb75a4d408214d21ff2afdff40 (diff) | |
| download | chromium_src-f87c00c2e047e67864a2b66b26659d2a86c4a112.zip chromium_src-f87c00c2e047e67864a2b66b26659d2a86c4a112.tar.gz chromium_src-f87c00c2e047e67864a2b66b26659d2a86c4a112.tar.bz2 | |
Revert of Enable Enterprise enrollment on desktop builds. (https://codereview.chromium.org/258743005/)
Reason for revert:
It seems to have broken the following test from
base_unittests and unit_tests on chromium.webkit Android Tests (dbg) builder:
PathServiceTest.Override
Log: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18922
Snippet from log:
C 237s Main [FAIL] PathServiceTest.Override:
C 237s Main ../../base/path_service_unittest.cc:184: Failure
C 237s Main Value of: PathService::OverrideAndCreateIfNeeded(my_special_key,
non_existent, false, false)
C 237s Main Actual: true
C 237s Main Expected: false
Original issue's description:
> Enable Enterprise enrollment on desktop builds.
>
> This change implements some of the DBus stub methods so that enterprise enrollment works on desktop builds. That will make development of features that depend on enrollment faster for developers that use this workflow (e.g. for kiosk enterprise apps, public accounts, testing some device policies, etc).
>
> - Override some of the directories and files involved with the enrollment state
> - Simple stub implementation of the DBus calls involved
> - Write a persistent cache of the install attributes
> - Cleaned up the stub for user cloud policy and made them persistent too
> - Updated some tests
>
> This change doesn't affect production code.
>
> TBR=jochen@chromium.org
> BUG=240269, 367674
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267640
TBR=brettw@chromium.org,nkostylev@chromium.org,pastarmovj@chromium.org,satorux@chromium.org,jochen@chromium.org,joaodasilva@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=240269, 367674
Review URL: https://codereview.chromium.org/265013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267761 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/path_service.h')
| -rw-r--r-- | base/path_service.h | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/base/path_service.h b/base/path_service.h index 554eb9e..9759754 100644 --- a/base/path_service.h +++ b/base/path_service.h @@ -46,18 +46,11 @@ class BASE_EXPORT PathService { // one test should not carry over to another. static bool Override(int key, const base::FilePath& path); - // This function does the same as PathService::Override but it takes extra - // parameters: - // - |is_absolute| indicates that |path| has already been expanded into an - // absolute path, otherwise MakeAbsoluteFilePath() will be used. This is - // useful to override paths that may not exist yet, since MakeAbsoluteFilePath - // fails for those. Note that MakeAbsoluteFilePath also expands symbolic - // links, even if path.IsAbsolute() is already true. - // - |create| guides whether the directory to be overriden must + // This function does the same as PathService::Override but it takes an extra + // parameter |create| which guides whether the directory to be overriden must // be created in case it doesn't exist already. static bool OverrideAndCreateIfNeeded(int key, const base::FilePath& path, - bool is_absolute, bool create); // To extend the set of supported keys, you can register a path provider, |