summaryrefslogtreecommitdiffstats
path: root/base/pickle.h
diff options
context:
space:
mode:
authorjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-25 03:08:13 +0000
committerjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-25 03:08:13 +0000
commitf60c32ba9d1a4ff406d057f684dd139212a7e2b3 (patch)
tree4a68779ec9455506f75a80630226291db21b1be1 /base/pickle.h
parent1d438cca3295d0de03785aa7140215766fc2cd82 (diff)
downloadchromium_src-f60c32ba9d1a4ff406d057f684dd139212a7e2b3.zip
chromium_src-f60c32ba9d1a4ff406d057f684dd139212a7e2b3.tar.gz
chromium_src-f60c32ba9d1a4ff406d057f684dd139212a7e2b3.tar.bz2
Add comment about use of virtual
See request in comments within: http://codereview.chromium.org/159800/ r=wtc Review URL: http://codereview.chromium.org/7967018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102672 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/pickle.h')
-rw-r--r--base/pickle.h5
1 files changed, 5 insertions, 0 deletions
diff --git a/base/pickle.h b/base/pickle.h
index d93fe86..65353de 100644
--- a/base/pickle.h
+++ b/base/pickle.h
@@ -50,6 +50,11 @@ class BASE_EXPORT Pickle {
// Initializes a Pickle as a deep copy of another Pickle.
Pickle(const Pickle& other);
+ // Note: There are no virtual methods in this class. This destructor is
+ // virtual as an element of defensive coding. Other classes have derived from
+ // this class, and there is a *chance* that they will cast into this base
+ // class before destruction. At least one such class does have a virtual
+ // destructor, suggesting at least some need to call more derived destructors.
virtual ~Pickle();
// Performs a deep copy.