diff options
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 08:46:45 +0000 |
|---|---|---|
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 08:46:45 +0000 |
| commit | 007b3f812fc9c989fb99d4a668d8bd9c7807ad81 (patch) | |
| tree | 43e69dd0f4e4dbbe68afb6319fa18cee07a4be64 /base/prefs | |
| parent | 2bde7e94eb8f402839145e48924391a5c645a554 (diff) | |
| download | chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.zip chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.tar.gz chromium_src-007b3f812fc9c989fb99d4a668d8bd9c7807ad81.tar.bz2 | |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/prefs')
| -rw-r--r-- | base/prefs/pref_change_registrar_unittest.cc | 2 | ||||
| -rw-r--r-- | base/prefs/pref_service_unittest.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/base/prefs/pref_change_registrar_unittest.cc b/base/prefs/pref_change_registrar_unittest.cc index 49da721..f353a8f 100644 --- a/base/prefs/pref_change_registrar_unittest.cc +++ b/base/prefs/pref_change_registrar_unittest.cc @@ -132,7 +132,7 @@ class ObserveSetOfPreferencesTest : public testing::Test { PrefRegistrySimple* registry = pref_service_->registry(); registry->RegisterStringPref(kHomePage, "http://google.com"); registry->RegisterBooleanPref(kHomePageIsNewTabPage, false); - registry->RegisterStringPref(kApplicationLocale, ""); + registry->RegisterStringPref(kApplicationLocale, std::string()); } PrefChangeRegistrar* CreatePrefChangeRegistrar() { diff --git a/base/prefs/pref_service_unittest.cc b/base/prefs/pref_service_unittest.cc index 26fe19a..927f2f7 100644 --- a/base/prefs/pref_service_unittest.cc +++ b/base/prefs/pref_service_unittest.cc @@ -45,7 +45,7 @@ TEST(PrefServiceTest, NoObserverFire) { Mock::VerifyAndClearExpectations(&obs); // Clearing the pref should cause the pref to fire. - const StringValue expected_default_value(""); + const StringValue expected_default_value((std::string())); obs.Expect(pref_name, &expected_default_value); prefs.ClearPref(pref_name); Mock::VerifyAndClearExpectations(&obs); |